Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1630)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc

Issue 1007523002: Update ES3 enums for texture parameters. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Two CLs combined Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc
index 994608cf5a894b14cb44b952d4db6820e5a6afd2..1f6949ca51f02726ec50d0c01b2fdfb67c734169 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc
@@ -2109,7 +2109,7 @@ TEST_P(GLES2DecoderManualInitTest, DepthTextureBadArgs) {
CopyTexImage2D copy_tex_cmd;
copy_tex_cmd.Init(GL_TEXTURE_2D, 0, GL_DEPTH_COMPONENT, 0, 0, 1, 1);
EXPECT_EQ(error::kNoError, ExecuteCmd(copy_tex_cmd));
- EXPECT_EQ(GL_INVALID_OPERATION, GetGLError());
+ EXPECT_EQ(GL_INVALID_ENUM, GetGLError());
no sievers 2015/03/13 00:15:54 Shouldn't this still be INVALID_OPERATION accordin
Zhenyao Mo 2015/03/13 02:38:33 According to the core spec, any internalformat not
no sievers 2015/03/13 19:44:18 OK looks like OpenGL 4 indeed says: " An invalid v
Zhenyao Mo 2015/03/13 20:25:14 Done.
// Check that trying to CopyTexSubImage2D fails
CopyTexSubImage2D copy_sub_cmd;

Powered by Google App Engine
This is Rietveld 408576698