Update ES3 enums for texture parameters.

gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
 
 #include "base/command_line.h"
 #include "base/strings/string_number_conversions.h"
 #include "gpu/command_buffer/common/gles2_cmd_format.h"
 #include "gpu/command_buffer/common/gles2_cmd_utils.h"
@@ skipping 2091 matching lines @@
                    kSharedMemoryId,
                    kSharedMemoryOffset,
                    GL_FALSE);
   EXPECT_EQ(error::kNoError, ExecuteCmd(tex_sub_cmd));
   EXPECT_EQ(GL_INVALID_OPERATION, GetGLError());
 
   // Check that trying to CopyTexImage2D fails
   CopyTexImage2D copy_tex_cmd;
   copy_tex_cmd.Init(GL_TEXTURE_2D, 0, GL_DEPTH_COMPONENT, 0, 0, 1, 1);
   EXPECT_EQ(error::kNoError, ExecuteCmd(copy_tex_cmd));
-  EXPECT_EQ(GL_INVALID_OPERATION, GetGLError());
+  EXPECT_EQ(GL_INVALID_ENUM, GetGLError());

[no sievers, 2015/03/13 00:15:54]

Shouldn't this still be INVALID_OPERATION according to the spec?

[Zhenyao Mo, 2015/03/13 02:38:33]

According to the core spec, any internalformat not in the list should generate
an INVALID_ENUM.  I think the ANGLE_depth_texture spec is incorrect.

[no sievers, 2015/03/13 19:44:18]

OK looks like OpenGL 4 indeed says:
" An invalid value specified for internalformat
generates the error INVALID_ENUM"


But ES3 says this:
'Table 3.15 summarizes the
valid framebuffer and texture base internal format combinations. If the
combination
is not valid, an INVALID_OPERATION error is generated.'

ANGLE_depth_texture says:

    "CopyTexImage2D and CopyTexSubImage2D generate the INVALID_OPERATION 
    error if the base internal format of the destination texture is 
    DEPTH_COMPONENT or DEPTH_STENCIL_OES.

And WebGL says nothing about it.

So I guess it doesn't matter :)

[Zhenyao Mo, 2015/03/13 20:25:14]

Done.

 
   // Check that trying to CopyTexSubImage2D fails
   CopyTexSubImage2D copy_sub_cmd;
   copy_sub_cmd.Init(GL_TEXTURE_2D, 0, 0, 0, 0, 0, 1, 1);
   EXPECT_EQ(error::kNoError, ExecuteCmd(copy_sub_cmd));
   EXPECT_EQ(GL_INVALID_OPERATION, GetGLError());
 }
 
 TEST_P(GLES2DecoderManualInitTest, GenerateMipmapDepthTexture) {
   InitState init;
@@ skipping 789 matching lines @@
 // TODO(gman): CompressedTexSubImage2DImmediate
 
 // TODO(gman): TexImage2D
 
 // TODO(gman): TexImage2DImmediate
 
 // TODO(gman): TexSubImage2DImmediate
 
 }  // namespace gles2
 }  // namespace gpu