Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 1007513006: Add ANGLE Platform implementation. (Closed)

Created:
5 years, 9 months ago by Jamie Madill
Modified:
5 years, 9 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, jam, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, piman+watch_chromium.org, kalyank, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ANGLE Platform implementation. *re-re-land with SwiftShader fix* *re-land with fix to components_browsertests* This logic allows us to record traces and histograms easily within ANGLE's code. It also gives a flexible design that we can extend with further methods later, without breaking compilation. The design is based on blink::Platform. Also add two new histogram descriptions to histograms.xml, and move the GPU Process metrics init to before InitializeOneOff, so ANGLE can record histograms during Renderer initialization. BUG=436191 TBR=jam@chromium.org, asvitkine@chromium.org, piman@chromium.org, maruel@chromium.org, kbr@chromium.org Committed: https://crrev.com/29fda863e960afecd39be697b54506877264a30f Cr-Commit-Position: refs/heads/master@{#321225}

Patch Set 1 #

Patch Set 2 : Fixed SwiftShader by loading functions dynamically #

Patch Set 3 : rebase #

Total comments: 4

Patch Set 4 : Addressed pimans' review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -20 lines) Patch
M ash/ash_unittests.isolate View 1 chunk +1 line, -0 lines 0 comments Download
M cc/cc_unittests.isolate View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/sync_integration_tests.isolate View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/unit_tests.isolate View 1 chunk +1 line, -0 lines 0 comments Download
M components/components_browsertests.isolate View 2 chunks +5 lines, -4 lines 0 comments Download
M components/components_unittests.isolate View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_browsertests.isolate View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_gpu.gypi View 1 chunk +1 line, -4 lines 0 comments Download
M content/content_unittests.isolate View 1 chunk +1 line, -0 lines 0 comments Download
M content/gpu/gpu_main.cc View 4 chunks +9 lines, -10 lines 0 comments Download
M extensions/extensions_browsertests.isolate View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/gpu_unittests.isolate View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +39 lines, -1 line 0 comments Download
M ui/gl/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/DEPS View 1 chunk +5 lines, -1 line 0 comments Download
A ui/gl/angle_platform_impl.h View 1 chunk +39 lines, -0 lines 0 comments Download
A ui/gl/angle_platform_impl.cc View 1 chunk +50 lines, -0 lines 0 comments Download
M ui/gl/gl.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl_implementation_win.cc View 1 2 3 6 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Jamie Madill
piman/kbr, PTAL: I modified the changes in ui/gl to load the ANGLE entry points dynamically. ...
5 years, 9 months ago (2015-03-18 19:12:12 UTC) #1
M-A Ruel
isolate still lgtm
5 years, 9 months ago (2015-03-18 19:15:59 UTC) #2
piman
https://codereview.chromium.org/1007513006/diff/40001/ui/gl/gl_implementation_win.cc File ui/gl/gl_implementation_win.cc (right): https://codereview.chromium.org/1007513006/diff/40001/ui/gl/gl_implementation_win.cc#newcode136 ui/gl/gl_implementation_win.cc:136: } I think we'd only want to do this ...
5 years, 9 months ago (2015-03-18 19:27:08 UTC) #3
Jamie Madill
PTAL https://codereview.chromium.org/1007513006/diff/40001/ui/gl/gl_implementation_win.cc File ui/gl/gl_implementation_win.cc (right): https://codereview.chromium.org/1007513006/diff/40001/ui/gl/gl_implementation_win.cc#newcode136 ui/gl/gl_implementation_win.cc:136: } On 2015/03/18 19:27:07, piman (Very slow to ...
5 years, 9 months ago (2015-03-18 21:01:50 UTC) #4
piman
lgtm
5 years, 9 months ago (2015-03-18 22:16:57 UTC) #5
Ken Russell (switch to Gerrit)
lgtm
5 years, 9 months ago (2015-03-18 22:17:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007513006/60001
5 years, 9 months ago (2015-03-18 22:37:59 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-18 22:45:41 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 22:46:08 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/29fda863e960afecd39be697b54506877264a30f
Cr-Commit-Position: refs/heads/master@{#321225}

Powered by Google App Engine
This is Rietveld 408576698