Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(43)

Issue 1007123003: Clear RenderFrameImpl::frame_ pointer after deleting it. (Closed)

Created:
4 years, 8 months ago by Charlie Reis
Modified:
4 years, 8 months ago
Reviewers:
nasko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear RenderFrameImpl::frame_ pointer after deleting it. Also avoid dereferencing it in OnMessageReceived after deletion. BUG=461191 TEST=No more crashes in RenderFrameImpl::OnMessageReceived Committed: https://crrev.com/cfaa4468f3394995a9f1565104ee2743a30d58e0 Cr-Commit-Position: refs/heads/master@{#320773}

Patch Set 1 #

Patch Set 2 : Add test #

Total comments: 2

Patch Set 3 : Update comment #

Patch Set 4 : Fix leaked message in test #

Patch Set 5 : Verify OnMessageReceived returns false #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2 lines) Patch
M content/renderer/render_frame_impl.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 chunks +9 lines, -1 line 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 2 3 4 1 chunk +25 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Charlie Reis
Nasko, can you take a look?
4 years, 8 months ago (2015-03-16 17:04:28 UTC) #2
nasko
Code looks good. Just one question/comment. https://codereview.chromium.org/1007123003/diff/20001/content/renderer/render_frame_impl.cc File content/renderer/render_frame_impl.cc (right): https://codereview.chromium.org/1007123003/diff/20001/content/renderer/render_frame_impl.cc#newcode2119 content/renderer/render_frame_impl.cc:2119: delete this; Based ...
4 years, 8 months ago (2015-03-16 17:12:18 UTC) #3
Charlie Reis
https://codereview.chromium.org/1007123003/diff/20001/content/renderer/render_frame_impl.cc File content/renderer/render_frame_impl.cc (right): https://codereview.chromium.org/1007123003/diff/20001/content/renderer/render_frame_impl.cc#newcode2119 content/renderer/render_frame_impl.cc:2119: delete this; On 2015/03/16 17:12:17, nasko wrote: > Based ...
4 years, 8 months ago (2015-03-16 17:21:19 UTC) #4
nasko
LGTM
4 years, 8 months ago (2015-03-16 17:40:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007123003/40001
4 years, 8 months ago (2015-03-16 17:43:49 UTC) #7
Charlie Reis
Fixed a leak in the test in patch 4.
4 years, 8 months ago (2015-03-16 18:07:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007123003/80001
4 years, 8 months ago (2015-03-16 18:12:28 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2015-03-16 19:27:30 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2015-03-16 19:28:07 UTC) #14
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/cfaa4468f3394995a9f1565104ee2743a30d58e0
Cr-Commit-Position: refs/heads/master@{#320773}

Powered by Google App Engine
This is Rietveld 408576698