Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: content/renderer/render_view_impl.h

Issue 1007123003: Clear RenderFrameImpl::frame_ pointer after deleting it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Verify OnMessageReceived returns false Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/render_view_browsertest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 510 matching lines...) Expand 10 before | Expand all | Expand 10 after
521 friend class PepperDeviceTest; 521 friend class PepperDeviceTest;
522 friend class RenderViewImplTest; 522 friend class RenderViewImplTest;
523 friend class RenderViewTest; 523 friend class RenderViewTest;
524 friend class RendererAccessibilityTest; 524 friend class RendererAccessibilityTest;
525 525
526 // TODO(nasko): Temporarily friend RenderFrameImpl, so we don't duplicate 526 // TODO(nasko): Temporarily friend RenderFrameImpl, so we don't duplicate
527 // utility functions needed in both classes, while we move frame specific 527 // utility functions needed in both classes, while we move frame specific
528 // code away from this class. 528 // code away from this class.
529 friend class RenderFrameImpl; 529 friend class RenderFrameImpl;
530 530
531 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, RenderFrameMessageAfterDetach);
531 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, DecideNavigationPolicyForWebUI); 532 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, DecideNavigationPolicyForWebUI);
532 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, 533 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest,
533 DidFailProvisionalLoadWithErrorForError); 534 DidFailProvisionalLoadWithErrorForError);
534 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, 535 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest,
535 DidFailProvisionalLoadWithErrorForCancellation); 536 DidFailProvisionalLoadWithErrorForCancellation);
536 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, ImeComposition); 537 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, ImeComposition);
537 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, InsertCharacters); 538 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, InsertCharacters);
538 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, JSBlockSentAfterPageLoad); 539 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, JSBlockSentAfterPageLoad);
539 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, LastCommittedUpdateState); 540 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, LastCommittedUpdateState);
540 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, OnHandleKeyboardEvent); 541 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, OnHandleKeyboardEvent);
(...skipping 508 matching lines...) Expand 10 before | Expand all | Expand 10 after
1049 // use the Observer interface to filter IPC messages and receive frame change 1050 // use the Observer interface to filter IPC messages and receive frame change
1050 // notifications. 1051 // notifications.
1051 // --------------------------------------------------------------------------- 1052 // ---------------------------------------------------------------------------
1052 1053
1053 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl); 1054 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl);
1054 }; 1055 };
1055 1056
1056 } // namespace content 1057 } // namespace content
1057 1058
1058 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 1059 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
OLDNEW
« no previous file with comments | « content/renderer/render_view_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698