Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 1006863002: Some minor touch-ups to the SVG content-model test framework (Closed)

Created:
5 years, 9 months ago by fs
Modified:
5 years, 9 months ago
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Some minor touch-ups to the SVG content-model test framework * Update references to filter spec. and make feDropShadow a proper filter primitive. * Rename needChld to needChild. * Sync tags table and classes with SVG2. * Minor simplifications to class expansion and child-creation. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191856

Patch Set 1 #

Patch Set 2 : Sync table w/ SVG2 #

Total comments: 3

Patch Set 3 : More SVG2 updates #

Total comments: 1

Patch Set 4 : Add text element classes. Drop some dead containers. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -70 lines) Patch
M LayoutTests/svg/dom/content-model.html View 2 chunks +7 lines, -14 lines 0 comments Download
M LayoutTests/svg/dom/content-model-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/dom/resources/svgtags.js View 1 2 3 2 chunks +72 lines, -55 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
fs
5 years, 9 months ago (2015-03-13 11:27:39 UTC) #2
Erik Dahlström (inactive)
lgtm
5 years, 9 months ago (2015-03-13 11:52:55 UTC) #3
fs
On 2015/03/13 11:52:55, Erik Dahlström wrote: > lgtm Synced the tags table w/ SVG2 a ...
5 years, 9 months ago (2015-03-13 12:03:05 UTC) #4
Erik Dahlström (inactive)
Some nits re patchset #2. The code changes are still lgtm. https://codereview.chromium.org/1006863002/diff/20001/LayoutTests/svg/dom/resources/svgtags.js File LayoutTests/svg/dom/resources/svgtags.js (right): ...
5 years, 9 months ago (2015-03-13 12:28:38 UTC) #5
fs
https://codereview.chromium.org/1006863002/diff/20001/LayoutTests/svg/dom/resources/svgtags.js File LayoutTests/svg/dom/resources/svgtags.js (right): https://codereview.chromium.org/1006863002/diff/20001/LayoutTests/svg/dom/resources/svgtags.js#newcode129 LayoutTests/svg/dom/resources/svgtags.js:129: // https://svgwg.org/svg2-draft/intro.html#TermPaintServerElement On 2015/03/13 12:28:38, Erik Dahlström wrote: > ...
5 years, 9 months ago (2015-03-13 12:30:05 UTC) #6
fs
Updated term URLs and synced the classes a bit. If you know of any additional ...
5 years, 9 months ago (2015-03-13 12:53:52 UTC) #7
Erik Dahlström (inactive)
On 2015/03/13 12:53:52, fs wrote: > Updated term URLs and synced the classes a bit. ...
5 years, 9 months ago (2015-03-13 13:52:27 UTC) #8
fs
On 2015/03/13 13:52:27, Erik Dahlström wrote: > On 2015/03/13 12:53:52, fs wrote: > > Updated ...
5 years, 9 months ago (2015-03-13 13:59:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006863002/60001
5 years, 9 months ago (2015-03-13 13:59:32 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 18:12:00 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191856

Powered by Google App Engine
This is Rietveld 408576698