Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: LayoutTests/svg/dom/content-model.html

Issue 1006863002: Some minor touch-ups to the SVG content-model test framework (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add text element classes. Drop some dead containers. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/svg/dom/content-model-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/svg/dom/content-model.html
diff --git a/LayoutTests/svg/dom/content-model.html b/LayoutTests/svg/dom/content-model.html
index 1dbae4cc5f32711b52f0f30c2ba243b5e98c3921..f463dd81c24828c6f5244887010d50588bf7c529 100644
--- a/LayoutTests/svg/dom/content-model.html
+++ b/LayoutTests/svg/dom/content-model.html
@@ -27,24 +27,17 @@
for (var attr in SvgTags[tag].needAttr)
node.setAttribute(attr, SvgTags[tag].needAttr[attr]);
- var requiredChildren = SvgTags[tag].needChld;
- if (requiredChildren) {
- for (var i = 0; i < requiredChildren.length; i++)
- createValidNode(requiredChildren[i], node, false);
- }
+ var requiredChildren = SvgTags[tag].needChild || [];
+ for (var childTag of requiredChildren)
+ createValidNode(childTag, node, false);
return node;
}
function expandClasses(tags) {
var expandedTags = [];
- for (var i = 0; i < tags.length; i++) {
- if (SvgTagClasses[tags[i]])
- expandedTags = expandedTags.concat(SvgTagClasses[tags[i]]);
- else
- expandedTags.push(tags[i]);
- }
-
+ for (var tag of tags)
+ Array.prototype.push.apply(expandedTags, SvgTagClasses[tag] || [tag]);
return expandedTags;
}
@@ -105,8 +98,8 @@
description('This test validates renderer instantiation against the SVG content model.');
validateTag('filter', [
- // http://www.w3.org/TR/SVG/filters.html#FilterElement
- 'CLASS_DESCRIPTIVE', 'CLASS_FILTER_PRIMITIVE', 'animate', 'feDropShadow', 'set'
+ // http://dev.w3.org/fxtf/filters/#FilterElement
+ 'CLASS_DESCRIPTIVE', 'CLASS_FILTER_PRIMITIVE', 'animate', 'set'
]);
</script>
</body>
« no previous file with comments | « no previous file | LayoutTests/svg/dom/content-model-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698