Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc

Issue 1006753003: Add time from navigation_start to NTP LogEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc ('k') | chrome/common/render_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc
diff --git a/chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc b/chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc
index adbee28d49d5915b78125759bb422b5cd28d2f81..59632f0ad2058ac9bf1b46576d56624bdc09a141 100644
--- a/chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc
+++ b/chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc
@@ -46,21 +46,23 @@ TEST(NTPUserDataLoggerTest, TestLogging) {
// Enusure non-zero statistics.
TestNTPUserDataLogger logger;
+ base::TimeDelta delta = base::TimeDelta::FromMilliseconds(0);
+
for (int i = 0; i < 20; ++i)
- logger.LogEvent(NTP_MOUSEOVER);
+ logger.LogEvent(NTP_MOUSEOVER, delta);
for (int i = 0; i < 8; ++i)
- logger.LogEvent(NTP_TILE);
+ logger.LogEvent(NTP_TILE, delta);
for (int i = 0; i < 4; ++i)
- logger.LogEvent(NTP_THUMBNAIL_TILE);
+ logger.LogEvent(NTP_THUMBNAIL_TILE, delta);
for (int i = 0; i < 2; ++i)
- logger.LogEvent(NTP_THUMBNAIL_ERROR);
- logger.LogEvent(NTP_GRAY_TILE_FALLBACK);
- logger.LogEvent(NTP_EXTERNAL_TILE_FALLBACK);
+ logger.LogEvent(NTP_THUMBNAIL_ERROR, delta);
+ logger.LogEvent(NTP_GRAY_TILE_FALLBACK, delta);
+ logger.LogEvent(NTP_EXTERNAL_TILE_FALLBACK, delta);
for (int i = 0; i < 2; ++i)
- logger.LogEvent(NTP_EXTERNAL_TILE);
+ logger.LogEvent(NTP_EXTERNAL_TILE, delta);
for (int i = 0; i < 2; ++i)
- logger.LogEvent(NTP_GRAY_TILE);
- logger.LogEvent(NTP_SERVER_SIDE_SUGGESTION);
+ logger.LogEvent(NTP_GRAY_TILE, delta);
+ logger.LogEvent(NTP_SERVER_SIDE_SUGGESTION, delta);
logger.EmitNtpStatistics();
« no previous file with comments | « chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc ('k') | chrome/common/render_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698