Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Side by Side Diff: chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc

Issue 1006753003: Add time from navigation_start to NTP LogEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc ('k') | chrome/common/render_messages.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/ntp/ntp_user_data_logger.h" 5 #include "chrome/browser/ui/webui/ntp/ntp_user_data_logger.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/metrics/histogram.h" 8 #include "base/metrics/histogram.h"
9 #include "base/metrics/statistics_recorder.h" 9 #include "base/metrics/statistics_recorder.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 28 matching lines...) Expand all
39 TEST(NTPUserDataLoggerTest, TestLogging) { 39 TEST(NTPUserDataLoggerTest, TestLogging) {
40 base::StatisticsRecorder::Initialize(); 40 base::StatisticsRecorder::Initialize();
41 41
42 // Ensure empty statistics. 42 // Ensure empty statistics.
43 EXPECT_EQ(0, GetTotalCount("NewTabPage.NumberOfMouseOvers")); 43 EXPECT_EQ(0, GetTotalCount("NewTabPage.NumberOfMouseOvers"));
44 EXPECT_EQ(0, GetBinCount("NewTabPage.NumberOfMouseOvers", 0)); 44 EXPECT_EQ(0, GetBinCount("NewTabPage.NumberOfMouseOvers", 0));
45 45
46 // Enusure non-zero statistics. 46 // Enusure non-zero statistics.
47 TestNTPUserDataLogger logger; 47 TestNTPUserDataLogger logger;
48 48
49 base::TimeDelta delta = base::TimeDelta::FromMilliseconds(0);
50
49 for (int i = 0; i < 20; ++i) 51 for (int i = 0; i < 20; ++i)
50 logger.LogEvent(NTP_MOUSEOVER); 52 logger.LogEvent(NTP_MOUSEOVER, delta);
51 for (int i = 0; i < 8; ++i) 53 for (int i = 0; i < 8; ++i)
52 logger.LogEvent(NTP_TILE); 54 logger.LogEvent(NTP_TILE, delta);
53 for (int i = 0; i < 4; ++i) 55 for (int i = 0; i < 4; ++i)
54 logger.LogEvent(NTP_THUMBNAIL_TILE); 56 logger.LogEvent(NTP_THUMBNAIL_TILE, delta);
55 for (int i = 0; i < 2; ++i) 57 for (int i = 0; i < 2; ++i)
56 logger.LogEvent(NTP_THUMBNAIL_ERROR); 58 logger.LogEvent(NTP_THUMBNAIL_ERROR, delta);
57 logger.LogEvent(NTP_GRAY_TILE_FALLBACK); 59 logger.LogEvent(NTP_GRAY_TILE_FALLBACK, delta);
58 logger.LogEvent(NTP_EXTERNAL_TILE_FALLBACK); 60 logger.LogEvent(NTP_EXTERNAL_TILE_FALLBACK, delta);
59 for (int i = 0; i < 2; ++i) 61 for (int i = 0; i < 2; ++i)
60 logger.LogEvent(NTP_EXTERNAL_TILE); 62 logger.LogEvent(NTP_EXTERNAL_TILE, delta);
61 for (int i = 0; i < 2; ++i) 63 for (int i = 0; i < 2; ++i)
62 logger.LogEvent(NTP_GRAY_TILE); 64 logger.LogEvent(NTP_GRAY_TILE, delta);
63 logger.LogEvent(NTP_SERVER_SIDE_SUGGESTION); 65 logger.LogEvent(NTP_SERVER_SIDE_SUGGESTION, delta);
64 66
65 logger.EmitNtpStatistics(); 67 logger.EmitNtpStatistics();
66 68
67 EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfMouseOvers")); 69 EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfMouseOvers"));
68 EXPECT_EQ(0, GetBinCount("NewTabPage.NumberOfMouseOvers", 0)); 70 EXPECT_EQ(0, GetBinCount("NewTabPage.NumberOfMouseOvers", 0));
69 EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfMouseOvers", 20)); 71 EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfMouseOvers", 20));
70 EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfTiles")); 72 EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfTiles"));
71 EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfTiles", 8)); 73 EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfTiles", 8));
72 EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfThumbnailTiles")); 74 EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfThumbnailTiles"));
73 EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfThumbnailTiles", 4)); 75 EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfThumbnailTiles", 4));
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 logger.LogMostVisitedNavigation(5, base::ASCIIToUTF16("")); 150 logger.LogMostVisitedNavigation(5, base::ASCIIToUTF16(""));
149 EXPECT_EQ(3, GetTotalCount("NewTabPage.MostVisited")); 151 EXPECT_EQ(3, GetTotalCount("NewTabPage.MostVisited"));
150 EXPECT_EQ(1, GetBinCount("NewTabPage.MostVisited.foobar", 1)); 152 EXPECT_EQ(1, GetBinCount("NewTabPage.MostVisited.foobar", 1));
151 EXPECT_EQ(1, GetBinCount("NewTabPage.MostVisited.foobar", 5)); 153 EXPECT_EQ(1, GetBinCount("NewTabPage.MostVisited.foobar", 5));
152 154
153 logger.LogMostVisitedNavigation(1, base::ASCIIToUTF16("foobar")); 155 logger.LogMostVisitedNavigation(1, base::ASCIIToUTF16("foobar"));
154 EXPECT_EQ(4, GetTotalCount("NewTabPage.MostVisited")); 156 EXPECT_EQ(4, GetTotalCount("NewTabPage.MostVisited"));
155 EXPECT_EQ(2, GetBinCount("NewTabPage.MostVisited.foobar", 1)); 157 EXPECT_EQ(2, GetBinCount("NewTabPage.MostVisited.foobar", 1));
156 EXPECT_EQ(1, GetBinCount("NewTabPage.MostVisited.foobar", 5)); 158 EXPECT_EQ(1, GetBinCount("NewTabPage.MostVisited.foobar", 5));
157 } 159 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc ('k') | chrome/common/render_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698