Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Unified Diff: chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc

Issue 1006753003: Add time from navigation_start to NTP LogEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc
diff --git a/chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc b/chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc
index adbee28d49d5915b78125759bb422b5cd28d2f81..0e20f34b1821795085fc6e250adf1aa6259e1bbc 100644
--- a/chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc
+++ b/chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc
@@ -47,20 +47,20 @@ TEST(NTPUserDataLoggerTest, TestLogging) {
TestNTPUserDataLogger logger;
for (int i = 0; i < 20; ++i)
- logger.LogEvent(NTP_MOUSEOVER);
+ logger.LogEvent(NTP_MOUSEOVER, 0);
for (int i = 0; i < 8; ++i)
- logger.LogEvent(NTP_TILE);
+ logger.LogEvent(NTP_TILE, 0);
for (int i = 0; i < 4; ++i)
- logger.LogEvent(NTP_THUMBNAIL_TILE);
+ logger.LogEvent(NTP_THUMBNAIL_TILE, 0);
for (int i = 0; i < 2; ++i)
- logger.LogEvent(NTP_THUMBNAIL_ERROR);
- logger.LogEvent(NTP_GRAY_TILE_FALLBACK);
- logger.LogEvent(NTP_EXTERNAL_TILE_FALLBACK);
+ logger.LogEvent(NTP_THUMBNAIL_ERROR, 0);
+ logger.LogEvent(NTP_GRAY_TILE_FALLBACK, 0);
+ logger.LogEvent(NTP_EXTERNAL_TILE_FALLBACK, 0);
for (int i = 0; i < 2; ++i)
- logger.LogEvent(NTP_EXTERNAL_TILE);
+ logger.LogEvent(NTP_EXTERNAL_TILE, 0);
for (int i = 0; i < 2; ++i)
- logger.LogEvent(NTP_GRAY_TILE);
- logger.LogEvent(NTP_SERVER_SIDE_SUGGESTION);
+ logger.LogEvent(NTP_GRAY_TILE, 0);
+ logger.LogEvent(NTP_SERVER_SIDE_SUGGESTION, 0);
logger.EmitNtpStatistics();

Powered by Google App Engine
This is Rietveld 408576698