Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: chrome/browser/ui/webui/ntp/ntp_user_data_logger.h

Issue 1006753003: Add time from navigation_start to NTP LogEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/metrics_handler.cc ('k') | chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/ntp/ntp_user_data_logger.h
diff --git a/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h b/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h
index e723c697899f52c7a5f59538860594a2356e0539..b31c9980b4427edf8e6d0aad21177060f0861d4f 100644
--- a/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h
+++ b/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h
@@ -41,9 +41,10 @@ class NTPUserDataLogger
// the tab/shutting down Chrome), or when the user navigates to a URL.
void EmitNtpStatistics();
- // Called each time an event occurs on the NTP that requires a counter to be
- // incremented.
- void LogEvent(NTPLoggingEventType event);
+ // Called when an event occurs on the NTP that requires a counter to be
+ // incremented. |time| is the delta time in ms from navigation start until
+ // this event happened.
+ void LogEvent(NTPLoggingEventType event, uint64 time);
James Hawkins 2015/03/19 20:10:07 Why not use TimeDelta? https://code.google.com/p/
fserb 2015/03/19 20:15:30 so... the problem is we are constructing this time
// Logs an impression on one of the Most Visited tiles by a given provider.
void LogMostVisitedImpression(int position, const base::string16& provider);
« no previous file with comments | « chrome/browser/ui/webui/metrics_handler.cc ('k') | chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698