chrome/browser/ui/webui/metrics_handler.cc - Issue 1006753003: Add time from navigation_start to NTP LogEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/metrics_handler.cc

Issue 1006753003: Add time from navigation_start to NTP LogEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/metrics_handler.cc

diff --git a/chrome/browser/ui/webui/metrics_handler.cc b/chrome/browser/ui/webui/metrics_handler.cc

index 58cc102b7bbc7645eb550daa567202cd627aba40..3ac9e018790abc463d5a0b414c038612b3edabf9 100644

--- a/chrome/browser/ui/webui/metrics_handler.cc

+++ b/chrome/browser/ui/webui/metrics_handler.cc

@@ -109,7 +109,7 @@ void MetricsHandler::HandleLogEventTime(const base::ListValue* args) {

void MetricsHandler::HandleLogMouseover(const base::ListValue* args) {

#if !defined(OS_ANDROID)

// Android uses native UI for NTP.

- NTPUserDataLogger::GetOrCreateFromWebContents(

James Hawkins 2015/03/19 19:59:59 Please don't change the styling, i.e., leave the n

fserb 2015/03/19 20:07:49 I think it was 'git cl format', reverted.

- web_ui()->GetWebContents())->LogEvent(NTP_MOUSEOVER);

+ NTPUserDataLogger::GetOrCreateFromWebContents(web_ui()->GetWebContents())

+ ->LogEvent(NTP_MOUSEOVER, 0);

#endif // !defined(OS_ANDROID)

}