chrome/browser/ui/webui/metrics_handler.cc - Issue 1006753003: Add time from navigation_start to NTP LogEvent

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/webui/metrics_handler.cc

Issue 1006753003: Add time from navigation_start to NTP LogEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/search/search_tab_helper_unittest.cc ('k') | chrome/browser/ui/webui/ntp/ntp_user_data_logger.h » ('j') | chrome/browser/ui/webui/ntp/ntp_user_data_logger.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/webui/metrics_handler.h"	5 #include "chrome/browser/ui/webui/metrics_handler.h"

6	6

7 #include "base/bind.h"	7 #include "base/bind.h"

8 #include "base/bind_helpers.h"	8 #include "base/bind_helpers.h"

9 #include "base/logging.h"	9 #include "base/logging.h"

10 #include "base/metrics/histogram.h"	10 #include "base/metrics/histogram.h"

(...skipping 91 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
102 CoreTabHelper* core_tab_helper = CoreTabHelper::FromWebContents(tab);	102 CoreTabHelper* core_tab_helper = CoreTabHelper::FromWebContents(tab);

103 core_tab_helper->set_new_tab_start_time(base::TimeTicks());	103 core_tab_helper->set_new_tab_start_time(base::TimeTicks());

104 } else {	104 } else {

105 NOTREACHED();	105 NOTREACHED();

106 }	106 }

107 }	107 }

108	108

109 void MetricsHandler::HandleLogMouseover(const base::ListValue* args) {	109 void MetricsHandler::HandleLogMouseover(const base::ListValue* args) {

110 #if !defined(OS_ANDROID)	110 #if !defined(OS_ANDROID)

111 // Android uses native UI for NTP.	111 // Android uses native UI for NTP.

112 NTPUserDataLogger::GetOrCreateFromWebContents(	112 NTPUserDataLogger::GetOrCreateFromWebContents(web_ui()->GetWebContents())
James Hawkins 2015/03/19 19:59:59 Please don't change the styling, i.e., leave the n Please don't change the styling, i.e., leave the newline. fserb 2015/03/19 20:07:49 I think it was 'git cl format', reverted. Show quoted text On 2015/03/19 19:59:59, James Hawkins wrote: > Please don't change the styling, i.e., leave the newline. I think it was 'git cl format', reverted.
113 web_ui()->GetWebContents())->LogEvent(NTP_MOUSEOVER);	113 ->LogEvent(NTP_MOUSEOVER, 0);

114 #endif // !defined(OS_ANDROID)	114 #endif // !defined(OS_ANDROID)

115 }	115 }

OLD	NEW