Issue 1006653002: Closes the pipe when a Binding is destroyed. This was always the intended

Issue 1006653002: Closes the pipe when a Binding is destroyed. This was always the intended (Closed)

Created:
5 years, 9 months ago by rudominer

Modified:
5 years, 9 months ago

Reviewers:
jamesr

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Closes the pipe when a Binding is destroyed. This was always the intended behavior. Note: No tests in this CL because jamesr@ is concurrently adding a bunch of tests in a separate CL and will test this new code there. R=jamesr@chromium.org, jamesr Committed: https://chromium.googlesource.com/external/mojo/+/79a851621b01a45b4c76f15fb4693dd29f09e562

Patch Set 1 #

Total comments: 1

Patch Set 2 : Replaces two calls with one call to Close(). #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	mojo/public/cpp/bindings/binding.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jamesr

https://codereview.chromium.org/1006653002/diff/1/mojo/public/cpp/bindings/binding.h File mojo/public/cpp/bindings/binding.h (right): https://codereview.chromium.org/1006653002/diff/1/mojo/public/cpp/bindings/binding.h#newcode104 mojo/public/cpp/bindings/binding.h:104: internal_router_->CloseMessagePipe(); instead of these two calls could you just ...

5 years, 9 months ago (2015-03-12 21:01:10 UTC) #2

rudominer

On 2015/03/12 21:01:10, jamesr wrote: > https://codereview.chromium.org/1006653002/diff/1/mojo/public/cpp/bindings/binding.h > File mojo/public/cpp/bindings/binding.h (right): > > https://codereview.chromium.org/1006653002/diff/1/mojo/public/cpp/bindings/binding.h#newcode104 > ...

5 years, 9 months ago (2015-03-12 21:07:52 UTC) #4

rudominer

5 years, 9 months ago (2015-03-12 21:11:15 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
79a851621b01a45b4c76f15fb4693dd29f09e562 (presubmit successful).

Expand Messages | Collapse Messages