mojo/public/cpp/bindings/binding.h - Issue 1006653002: Closes the pipe when a Binding is destroyed. This was always the intended

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/binding.h

Issue 1006653002: Closes the pipe when a Binding is destroyed. This was always the intended (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Replaces two calls with one call to Close(). Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/public/cpp/bindings/binding.h

diff --git a/mojo/public/cpp/bindings/binding.h b/mojo/public/cpp/bindings/binding.h

index f178431c3f9d5731d669c390c468946cb2bf71a6..a982bdbd4b10642837f8e1306253f0832f43e95b 100644

--- a/mojo/public/cpp/bindings/binding.h

+++ b/mojo/public/cpp/bindings/binding.h

@@ -101,7 +101,7 @@ class Binding : public ErrorHandler {

// implementation unbound.

~Binding() override {

if (internal_router_) {

- DestroyRouter();

+ Close();

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »