Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 100653002: Introduce GenericFontFamilySettings. (Closed)

Created:
7 years ago by dglazkov
Modified:
7 years ago
CC:
blink-reviews, devtools-reviews_chromium.org, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, darktears, aandrey+blink_chromium.org
Visibility:
Public.

Description

Introduce GenericFontFamilySettings. The newborn will hold all settings, related to generic font families, and will be used by Settings. Aside from mechanical extraction, there is one functional change: setting font families will require explicit call to recalc style on all frames. Thankfully, this is already done in most places, aside from InternalSettings, where I added it. R=eae,ksakamoto@chromium.org BUG=324991 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163117

Patch Set 1 #

Patch Set 2 : Added missing PLATFORM_EXPORT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -192 lines) Patch
M Source/core/css/CSSFontSelector.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/css/resolver/FontBuilder.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorOverlay.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/page/Settings.h View 4 chunks +3 lines, -44 lines 0 comments Download
M Source/core/page/Settings.cpp View 3 chunks +0 lines, -108 lines 0 comments Download
M Source/core/testing/InternalSettings.cpp View 2 chunks +36 lines, -16 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A Source/platform/fonts/GenericFontFamilySettings.h View 1 1 chunk +100 lines, -0 lines 0 comments Download
A Source/platform/fonts/GenericFontFamilySettings.cpp View 1 chunk +142 lines, -0 lines 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
dglazkov
7 years ago (2013-12-03 00:24:14 UTC) #1
eseidel
lgtm. copy pasta! dglazkov and I discussed that in the long-term we plan to remove ...
7 years ago (2013-12-03 00:33:27 UTC) #2
Kunihiko Sakamoto
lgtm
7 years ago (2013-12-03 01:33:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/100653002/1
7 years ago (2013-12-03 04:34:11 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout&number=14763
7 years ago (2013-12-03 05:29:00 UTC) #5
dglazkov
Trying to figure out what these try fails are about...
7 years ago (2013-12-03 18:17:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/100653002/20001
7 years ago (2013-12-03 20:52:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/100653002/20001
7 years ago (2013-12-03 21:01:25 UTC) #8
commit-bot: I haz the power
7 years ago (2013-12-03 22:51:08 UTC) #9
Message was sent while issue was closed.
Change committed as 163117

Powered by Google App Engine
This is Rietveld 408576698