Source/bindings/templates/union.h - Issue 1006323002: [bindings] Pass v8::Local<v8::Value> by value in NativeValueTraits<T>::nativeValue()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/union.h

Issue 1006323002: [bindings] Pass v8::Local<v8::Value> by value in NativeValueTraits<T>::nativeValue() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/templates/union.h

diff --git a/Source/bindings/templates/union.h b/Source/bindings/templates/union.h

index 468492a616f6e2cd4619f7cdd7e8cad4c84c04b7..1a61acfbb4b036822176c31fb23e45dadf9b5180 100644

--- a/Source/bindings/templates/union.h

+++ b/Source/bindings/templates/union.h

@@ -66,7 +66,7 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, {{container.cpp_c

template <>

struct NativeValueTraits<{{container.cpp_class}}> {

- static {{container.cpp_class}} nativeValue(const v8::Local<v8::Value>&, v8::Isolate*, ExceptionState&);

+ static {{container.cpp_class}} nativeValue(v8::Local<v8::Value>, v8::Isolate*, ExceptionState&);

};

{% endfor %}

« no previous file with comments | « Source/bindings/templates/dictionary_v8.cpp ('k') | Source/bindings/templates/union.cpp » ('j') | no next file with comments »