Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 100613002: gyp_chromium integration for automatic toolchain (Closed)

Created:
7 years ago by scottmg
Modified:
7 years ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

gyp_chromium integration for automatic toolchain When opting in via GYP_MSVS_USE_SYSTEM_TOOLCHAIN=0, set environment variables that tell gyp how to find the automatic toolchain in third_party/win_toolchain. R=maruel@chromium.org BUG=323300 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238426

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : comment #

Total comments: 6

Patch Set 4 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M build/gyp_chromium View 1 2 3 2 chunks +29 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scottmg
7 years ago (2013-12-03 00:19:20 UTC) #1
M-A Ruel
lgtm with style nits https://codereview.chromium.org/100613002/diff/40001/build/gyp_chromium File build/gyp_chromium (right): https://codereview.chromium.org/100613002/diff/40001/build/gyp_chromium#newcode158 build/gyp_chromium:158: if sys.platform in ('win32', 'cygwin') ...
7 years ago (2013-12-03 13:44:56 UTC) #2
scottmg
https://codereview.chromium.org/100613002/diff/40001/build/gyp_chromium File build/gyp_chromium (right): https://codereview.chromium.org/100613002/diff/40001/build/gyp_chromium#newcode158 build/gyp_chromium:158: if sys.platform in ('win32', 'cygwin') and \ On 2013/12/03 ...
7 years ago (2013-12-03 17:42:02 UTC) #3
scottmg
7 years ago (2013-12-03 17:48:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r238426 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698