Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: build/gyp_chromium

Issue 100613002: gyp_chromium integration for automatic toolchain (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/gyp_chromium
diff --git a/build/gyp_chromium b/build/gyp_chromium
index dcba02327f02d3682542e0dfba46e6be67533a02..7ed4686346e2992239f78ca8c26a3a1bfa98d6cf 100755
--- a/build/gyp_chromium
+++ b/build/gyp_chromium
@@ -10,6 +10,7 @@
import glob
import gyp_helper
import os
+import pipes
import shlex
import subprocess
import sys
@@ -151,6 +152,34 @@ if __name__ == '__main__':
not 'OS=ios' in os.environ.get('GYP_DEFINES', []):
os.environ['GYP_GENERATORS'] = 'ninja'
+ # If using ninja on windows, and not opting out of the the automatic
+ # toolchain, then set up variables for the automatic toolchain. Opt-out is
+ # on by default, for now.
+ if (sys.platform in ('win32', 'cygwin') and
+ os.environ.get('GYP_GENERATORS') == 'ninja' and
+ os.environ.get('GYP_MSVS_USE_SYSTEM_TOOLCHAIN', '1') != '1'):
+ # For now, call the acquisition script here so that there's only one
+ # opt-in step required. This will be moved to a separate DEPS step once
+ # it's on by default.
+ subprocess.check_call([
+ sys.executable,
+ os.path.normpath(os.path.join(script_dir, '..', 'tools', 'win',
+ 'toolchain',
+ 'get_toolchain_if_necessary.py'))])
+ toolchain = os.path.normpath(os.path.join(
+ script_dir, '..', 'third_party', 'win_toolchain', 'files'))
+ os.environ['GYP_MSVS_OVERRIDE_PATH'] = toolchain
+ os.environ['GYP_MSVS_VERSION'] = '2013'
+ # We need to make sure windows_sdk_path is set to the automated toolchain
+ # values in GYP_DEFINES, but don't want to override any other values there.
+ gyp_defines_dict = gyp.NameValueListToDict(gyp.ShlexEnv('GYP_DEFINES'))
+ win8sdk = os.path.join(toolchain, 'win8sdk')
+ gyp_defines_dict['windows_sdk_path'] = win8sdk
+ os.environ['WINDOWSSDKDIR'] = win8sdk
+ os.environ['GYP_DEFINES'] = ' '.join('%s=%s' % (k, pipes.quote(str(v)))
+ for k, v in gyp_defines_dict.iteritems())
+ print('Using automatic toolchain in %s.' % toolchain)
+
# If CHROMIUM_GYP_SYNTAX_CHECK is set to 1, it will invoke gyp with --check
# to enfore syntax checking.
syntax_check = os.environ.get('CHROMIUM_GYP_SYNTAX_CHECK')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698