Cap chrome.mdns.onServiceList listeners per extension at 10

Set max number of mdns listeners per extension to 10.

BUG=451527
Committed: https://crrev.com/96ac2bf6fb4ef371d843155c50161fdf0e0dabf8
Cr-Commit-Position: refs/heads/master@{#323110}

[Red Daly, 2015-03-26 22:40:20]

reddaly@chromium.org changed reviewers:
+ benwells@chromium.org, mfoltz@chromium.org

[Red Daly, 2015-03-26 22:41:48]

On 2015/03/26 22:40:20, Red Daly wrote:
> mailto:reddaly@chromium.org changed reviewers:
> + mailto:benwells@chromium.org, mailto:mfoltz@chromium.org

Please note most of these changes were already LGTMed in another review that has
not been submitted yet:
https://codereview.chromium.org/668983003/

Should I go ahead and submit the above change to simplify the diff?

[Red Daly, 2015-03-27 23:52:32]

Patchset #1 (id:1) has been deleted

[Red Daly, 2015-03-27 23:53:24]

Patchset #1 (id:20001) has been deleted

[Red Daly, 2015-03-27 23:53:51]

On 2015/03/26 22:41:48, Red Daly wrote:
> On 2015/03/26 22:40:20, Red Daly wrote:
> > mailto:reddaly@chromium.org changed reviewers:
> > + mailto:benwells@chromium.org, mailto:mfoltz@chromium.org
> 
> Please note most of these changes were already LGTMed in another review that
has
> not been submitted yet:
> https://codereview.chromium.org/668983003/
> 
> Should I go ahead and submit the above change to simplify the diff?

I submitted the other CL.  This change is now ready for review.

[mark a. foltz, 2015-03-30 17:44:57]

https://codereview.chromium.org/1005903005/diff/40001/chrome/common/extension...
File chrome/common/extensions/api/mdns.idl (right):

https://codereview.chromium.org/1005903005/diff/40001/chrome/common/extension...
chrome/common/extensions/api/mdns.idl:33: [supportsFilters=true,
maxListeners=10] static void onServiceList(MDnsService[] services);
Does this restrict the number of unique services listened for, or the total
number of event handlers registered with the API?

https://codereview.chromium.org/1005903005/diff/40001/chrome/test/data/extens...
File chrome/test/data/extensions/api_test/mdns/api-packaged-apps/manifest.json
(right):

https://codereview.chromium.org/1005903005/diff/40001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/mdns/api-packaged-apps/manifest.json:4:
"name": "MDNS Extension",
Is this an extension or an app?

https://codereview.chromium.org/1005903005/diff/40001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/mdns/api-packaged-apps/manifest.json:6:
"description": "Test MDNS Extension",
Ditto

https://codereview.chromium.org/1005903005/diff/40001/chrome/test/data/extens...
File
chrome/test/data/extensions/api_test/mdns/api-packaged-apps/register_too_many_listeners.js
(right):

https://codereview.chromium.org/1005903005/diff/40001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/mdns/api-packaged-apps/register_too_many_listeners.js:1:
// Copyright 2013 The Chromium Authors. All rights reserved.
Update copyright

https://codereview.chromium.org/1005903005/diff/40001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/mdns/api-packaged-apps/register_too_many_listeners.js:31:
failedToAddLast = true;
Assert that the exception is actually for too many listeners?

[Red Daly, 2015-03-30 20:28:34]

https://codereview.chromium.org/1005903005/diff/40001/chrome/common/extension...
File chrome/common/extensions/api/mdns.idl (right):

https://codereview.chromium.org/1005903005/diff/40001/chrome/common/extension...
chrome/common/extensions/api/mdns.idl:33: [supportsFilters=true,
maxListeners=10] static void onServiceList(MDnsService[] services);
On 2015/03/30 17:44:57, mark a. foltz wrote:
> Does this restrict the number of unique services listened for, or the total
> number of event handlers registered with the API?

The total number of event handlers.

I'm unsure of the best approach if we want to directly restrict the number of
unique service types for which an extension can listen.  The restriction should
happen when onServiceList.addListener is called so an error can be returned.  I
think I could achieve that by modifying event.js
(https://code.google.com/p/chromium/codesearch#chromium/src/extensions/rendere...),
or somehow creating a "subclass" of EventImpl for onServiceList events, and
adding the restriction there.

Any thoughts?

https://codereview.chromium.org/1005903005/diff/40001/chrome/test/data/extens...
File chrome/test/data/extensions/api_test/mdns/api-packaged-apps/manifest.json
(right):

https://codereview.chromium.org/1005903005/diff/40001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/mdns/api-packaged-apps/manifest.json:4:
"name": "MDNS Extension",
On 2015/03/30 17:44:57, mark a. foltz wrote:
> Is this an extension or an app?

Done.

https://codereview.chromium.org/1005903005/diff/40001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/mdns/api-packaged-apps/manifest.json:6:
"description": "Test MDNS Extension",
On 2015/03/30 17:44:57, mark a. foltz wrote:
> Ditto

Done.

https://codereview.chromium.org/1005903005/diff/40001/chrome/test/data/extens...
File
chrome/test/data/extensions/api_test/mdns/api-packaged-apps/register_too_many_listeners.js
(right):

https://codereview.chromium.org/1005903005/diff/40001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/mdns/api-packaged-apps/register_too_many_listeners.js:1:
// Copyright 2013 The Chromium Authors. All rights reserved.
On 2015/03/30 17:44:57, mark a. foltz wrote:
> Update copyright

Done.

https://codereview.chromium.org/1005903005/diff/40001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/mdns/api-packaged-apps/register_too_many_listeners.js:31:
failedToAddLast = true;
On 2015/03/30 17:44:57, mark a. foltz wrote:
> Assert that the exception is actually for too many listeners?

Done.  (This depends on string matching the error message.  If there's another
way you think we could specify the error type, I can modify EventImpl
accordingly.)

[benwells, 2015-03-30 22:44:50]

Do you just need me to look at the idl, or all of the patch?

[Red Daly, 2015-03-30 23:01:54]

On 2015/03/30 22:44:50, benwells wrote:
> Do you just need me to look at the idl, or all of the patch?

You only need to review the idl, unless Mark would like you to look at the whole
patch.

[benwells, 2015-03-30 23:31:12]

idl lgtm

[mark a. foltz, 2015-03-31 17:18:52]

lgtm

[Red Daly, 2015-03-31 19:39:12]

The CQ bit was checked by reddaly@chromium.org

[Red Daly, 2015-03-31 19:39:13]

The patchset sent to the CQ was uploaded after l-g-t-m from mfoltz@chromium.org,
benwells@chromium.org
Link to the patchset: https://codereview.chromium.org/1005903005/#ps80001
(title: "Rebase onto HEAD and consolidate changes into one commit")

[commit-bot: I haz the power, 2015-03-31 19:39:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1005903005/80001

[commit-bot: I haz the power, 2015-03-31 21:15:29]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-03-31 21:17:03]

Patchset 3 (id:??) landed as
https://crrev.com/96ac2bf6fb4ef371d843155c50161fdf0e0dabf8
Cr-Commit-Position: refs/heads/master@{#323110}