chrome/test/data/extensions/api_test/mdns/api-packaged-apps/manifest.json - Issue 1005903005: Cap chrome.mdns.onServiceList listeners per extension at 10

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/mdns/api-packaged-apps/manifest.json

Issue 1005903005: Cap chrome.mdns.onServiceList listeners per extension at 10 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add maxListeners limit in mdns.idl and corresponding browser test Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/common/extensions/api/mdns.idl ('K') | « chrome/common/extensions/api/mdns.idl ('k') | chrome/test/data/extensions/api_test/mdns/api-packaged-apps/register_too_many_listeners.js » ('j') | chrome/test/data/extensions/api_test/mdns/api-packaged-apps/register_too_many_listeners.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {	1 {

2 "key": "MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQC8xv6iO+j4kzj1HiBL93+XVJH/CRyAQM UHS/Z0l8nCAzaAFkW/JsNwxJqQhrZspnxLqbQxNncXs6g6bsXAwKHiEs+LSs+bIv0Gc/2ycZdhXJ8GhE sSMakog5dpQd1681c2gLK/8CrAoewE/0GIKhaFcp7a2iZlGh4Am6fgMKy0iQIDAQAB",	2 "key": "MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQC8xv6iO+j4kzj1HiBL93+XVJH/CRyAQM UHS/Z0l8nCAzaAFkW/JsNwxJqQhrZspnxLqbQxNncXs6g6bsXAwKHiEs+LSs+bIv0Gc/2ycZdhXJ8GhE sSMakog5dpQd1681c2gLK/8CrAoewE/0GIKhaFcp7a2iZlGh4Am6fgMKy0iQIDAQAB",

3 "manifest_version": 2,	3 "manifest_version": 2,

4 "name": "MDNS Extension",	4 "name": "MDNS Extension",
	mark a. foltz 2015/03/30 17:44:57 Is this an extension or an app? Is this an extension or an app? Red Daly 2015/03/30 20:28:34 Done. Show quoted text On 2015/03/30 17:44:57, mark a. foltz wrote: > Is this an extension or an app? Done.
5 "version": "1.0",	5 "version": "1.0",

6 "description": "Test MDNS Extension",	6 "description": "Test MDNS Extension",
	mark a. foltz 2015/03/30 17:44:57 Ditto Ditto Red Daly 2015/03/30 20:28:34 Done. Show quoted text On 2015/03/30 17:44:57, mark a. foltz wrote: > Ditto Done.
7 "permissions": ["mdns"]	7 "permissions": ["mdns"],

	8 "app": {

	9 "background": {

	10 "scripts": ["register_too_many_listeners.js"],

	11 "persistent": true

	12 }

	13 }

8 }	14 }

OLD	NEW