chrome/app/chrome_command_ids.h - Issue 1005873012: Makes bookmark menu lazily create menus and removes limits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/chrome_command_ids.h

Issue 1005873012: Makes bookmark menu lazily create menus and removes limits (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cleanup Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/app/chrome_command_ids.h

diff --git a/chrome/app/chrome_command_ids.h b/chrome/app/chrome_command_ids.h

index 6db8daf00919a3b82afc6bbcd94dc9d74861f0ae..505ce7cc9d27f8e8aa3c0f368139fc301ebf4319 100644

--- a/chrome/app/chrome_command_ids.h

+++ b/chrome/app/chrome_command_ids.h

@@ -361,4 +361,8 @@

// NOTE: The last valid command value is 57343 (0xDFFF)

// See http://msdn.microsoft.com/en-us/library/t2zechd4(VS.71).aspx

+// Starting command if for Menus showing bookmarks (such as the wrench menu).

+// These values are > 0xDFFF as the ids are not exposed to the native system.

Peter Kasting 2015/03/30 21:35:24 Nit: Maybe this second sentence: "While command ID

sky 2015/03/31 15:17:38 Done.

+#define IDC_FIRST_BOOKMARK_MENU 0xDFFF + 1

Peter Kasting 2015/03/30 21:35:24 Nit: "0xE000" seems a bit less obtuse.

sky 2015/03/31 15:17:39 Done.

#endif // CHROME_APP_CHROME_COMMAND_IDS_H_

« no previous file with comments | « no previous file | chrome/browser/ui/toolbar/wrench_menu_model.h » ('j') | chrome/browser/ui/toolbar/wrench_menu_model.h » ('J')