chrome/app/chrome_command_ids.h - Issue 1005873012: Makes bookmark menu lazily create menus and removes limits

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/app/chrome_command_ids.h

Issue 1005873012: Makes bookmark menu lazily create menus and removes limits (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cleanup Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/toolbar/wrench_menu_model.h » ('j') | chrome/browser/ui/toolbar/wrench_menu_model.h » ('J')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_APP_CHROME_COMMAND_IDS_H_	5 #ifndef CHROME_APP_CHROME_COMMAND_IDS_H_

6 #define CHROME_APP_CHROME_COMMAND_IDS_H_	6 #define CHROME_APP_CHROME_COMMAND_IDS_H_

7	7

8 // This file lists all the command IDs understood by e.g. the browser.	8 // This file lists all the command IDs understood by e.g. the browser.

9 // It is used by Windows RC files, Mac NIB files, and other platforms too.	9 // It is used by Windows RC files, Mac NIB files, and other platforms too.

10	10

(...skipping 343 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
354 #define IDC_MEDIA_STREAM_DEVICE_ALWAYS_ALLOW 51400	354 #define IDC_MEDIA_STREAM_DEVICE_ALWAYS_ALLOW 51400

355	355

356 // Protocol handler menu entries	356 // Protocol handler menu entries

357 #define IDC_CONTENT_CONTEXT_PROTOCOL_HANDLER_FIRST 52000	357 #define IDC_CONTENT_CONTEXT_PROTOCOL_HANDLER_FIRST 52000

358 #define IDC_CONTENT_CONTEXT_PROTOCOL_HANDLER_LAST 52199	358 #define IDC_CONTENT_CONTEXT_PROTOCOL_HANDLER_LAST 52199

359 #define IDC_CONTENT_CONTEXT_PROTOCOL_HANDLER_SETTINGS 52200	359 #define IDC_CONTENT_CONTEXT_PROTOCOL_HANDLER_SETTINGS 52200

360	360

361 // NOTE: The last valid command value is 57343 (0xDFFF)	361 // NOTE: The last valid command value is 57343 (0xDFFF)

362 // See http://msdn.microsoft.com/en-us/library/t2zechd4(VS.71).aspx	362 // See http://msdn.microsoft.com/en-us/library/t2zechd4(VS.71).aspx

363	363

	364 // Starting command if for Menus showing bookmarks (such as the wrench menu).

	365 // These values are > 0xDFFF as the ids are not exposed to the native system.
	Peter Kasting 2015/03/30 21:35:24 Nit: Maybe this second sentence: "While command ID Nit: Maybe this second sentence: "While command IDs passed to Windows functions must not be higher than 0xDFFF, these IDs are not exposed to the native system and thus can be in this otherwise-reserved range." sky 2015/03/31 15:17:38 Done. Show quoted text On 2015/03/30 21:35:24, Peter Kasting wrote: > Nit: Maybe this second sentence: "While command IDs passed to Windows functions > must not be higher than 0xDFFF, these IDs are not exposed to the native system > and thus can be in this otherwise-reserved range." Done.
	366 #define IDC_FIRST_BOOKMARK_MENU 0xDFFF + 1
	Peter Kasting 2015/03/30 21:35:24 Nit: "0xE000" seems a bit less obtuse. Nit: "0xE000" seems a bit less obtuse. sky 2015/03/31 15:17:39 Done. Show quoted text On 2015/03/30 21:35:24, Peter Kasting wrote: > Nit: "0xE000" seems a bit less obtuse. Done.
	367

364 #endif // CHROME_APP_CHROME_COMMAND_IDS_H_	368 #endif // CHROME_APP_CHROME_COMMAND_IDS_H_

OLD	NEW