Allow for GN Grit targets to depend on a stamp file instead of the first output in the .grd file.

Allow for GN Grit targets to depend on a stamp file instead of the first output in the .grd file.

BUG=466315
Committed: https://crrev.com/8915cf1873c38e62f4df71c9213b2a8918098a94
Cr-Commit-Position: refs/heads/master@{#320903}

[knn, 2015-03-13 12:52:39]

knn@chromium.org changed reviewers:
+ bauerb@chromium.org, brettw@chromium.org, cjhopman@chromium.org,
thakis@chromium.org

[knn, 2015-03-13 12:52:40]

Gn counterpart of the change,
https://codereview.chromium.org/997813004/

[cjhopman, 2015-03-14 00:37:45]

https://codereview.chromium.org/1005763003/diff/1/build/secondary/tools/grit/...
File build/secondary/tools/grit/grit_rule.gni (right):

https://codereview.chromium.org/1005763003/diff/1/build/secondary/tools/grit/...
build/secondary/tools/grit/grit_rule.gni:367: depend_on_stamp =
Do we need to support not depending on a stamp?

[knn, 2015-03-16 10:42:19]

Patchset #2 (id:20001) has been deleted

[knn, 2015-03-16 10:53:42]

PTAL.

https://codereview.chromium.org/1005763003/diff/1/build/secondary/tools/grit/...
File build/secondary/tools/grit/grit_rule.gni (right):

https://codereview.chromium.org/1005763003/diff/1/build/secondary/tools/grit/...
build/secondary/tools/grit/grit_rule.gni:367: depend_on_stamp =
On 2015/03/14 00:37:45, cjhopman wrote:
> Do we need to support not depending on a stamp?

This only so that the build does not break due to an unrecognized flag. Added a
TODO to remove.

[knn, 2015-03-16 10:58:48]

On 2015/03/16 10:53:42, knn wrote:
> PTAL.
> 
>
https://codereview.chromium.org/1005763003/diff/1/build/secondary/tools/grit/...
> File build/secondary/tools/grit/grit_rule.gni (right):
> 
>
https://codereview.chromium.org/1005763003/diff/1/build/secondary/tools/grit/...
> build/secondary/tools/grit/grit_rule.gni:367: depend_on_stamp =
> On 2015/03/14 00:37:45, cjhopman wrote:
> > Do we need to support not depending on a stamp?
> 
This only so that the build does not break due to an unrecognized flag. Added a
TODO to remove.
Also rolling grit first is difficult as there is a dependency on a previous grit
change I submitted.

[cjhopman, 2015-03-16 20:13:47]

https://codereview.chromium.org/1005763003/diff/1/build/secondary/tools/grit/...
File build/secondary/tools/grit/grit_rule.gni (right):

https://codereview.chromium.org/1005763003/diff/1/build/secondary/tools/grit/...
build/secondary/tools/grit/grit_rule.gni:367: depend_on_stamp =
On 2015/03/16 10:53:42, knn wrote:
> On 2015/03/14 00:37:45, cjhopman wrote:
> > Do we need to support not depending on a stamp?
> 
> This only so that the build does not break due to an unrecognized flag. Added
a
> TODO to remove.
But, we can't set depend_on_stamp for any target until grit is rolled anyway,
right?

[knn, 2015-03-16 20:27:13]

On 2015/03/16 20:13:47, cjhopman wrote:
>
https://codereview.chromium.org/1005763003/diff/1/build/secondary/tools/grit/...
> File build/secondary/tools/grit/grit_rule.gni (right):
> 
>
https://codereview.chromium.org/1005763003/diff/1/build/secondary/tools/grit/...
> build/secondary/tools/grit/grit_rule.gni:367: depend_on_stamp =
> On 2015/03/16 10:53:42, knn wrote:
> > On 2015/03/14 00:37:45, cjhopman wrote:
> > > Do we need to support not depending on a stamp?
> > 
> > This only so that the build does not break due to an unrecognized flag.
Added
> a
> > TODO to remove.
> But, we can't set depend_on_stamp for any target until grit is rolled anyway,
> right?

Yes, so this change will be ineffective till grit is rolled. If I remove the
flag, grit will have to roll before this change (which is difficult since there
is already a dependency on grit from my previous change
https://codereview.chromium.org/997523002/.

Alternatively I could merge this change with
https://codereview.chromium.org/997523002/ and remove the flag.

[cjhopman, 2015-03-16 20:30:21]

lgtm

[knn, 2015-03-17 12:36:33]

The CQ bit was checked by knn@chromium.org

[commit-bot: I haz the power, 2015-03-17 12:36:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1005763003/40001

[commit-bot: I haz the power, 2015-03-17 12:57:21]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-03-17 12:58:13]

Patchset 2 (id:??) landed as
https://crrev.com/8915cf1873c38e62f4df71c9213b2a8918098a94
Cr-Commit-Position: refs/heads/master@{#320903}