Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1005693002: PPC: [turbofan] Introduce optional Float64Min and Float64Max machine operators. (Closed)

Created:
5 years, 9 months ago by michael_dawson
Modified:
5 years, 9 months ago
Reviewers:
dcarney, Sven Panne, danno
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [turbofan] Introduce optional Float64Min and Float64Max machine operators. Port 99f8d57f3c5d967bc3b10356b22d7ec7be55e89f Original commit message: Basically recognize certain x < y ? x : y constructs and turn that into Float64Min/Float64Max operations, if the target machine supports that. On x86 we lower to (v)minsd/(v)maxsd. R=dcarney@chromium.org Review URL: https://codereview.chromium.org/998283002 Cr-Commit-Position: refs/heads/master@{#27160} R=danno@chromium.org, svenpanne@chromium.org BUG= Committed: https://crrev.com/0697e929529b9467f6f5fe04509d57ff8e22c098 Cr-Commit-Position: refs/heads/master@{#27174}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
michael_dawson
PPC Fix for next breaking change.
5 years, 9 months ago (2015-03-12 19:15:14 UTC) #1
michael_dawson
On 2015/03/12 19:15:14, michael_dawson wrote: > PPC Fix for next breaking change. I'll have to ...
5 years, 9 months ago (2015-03-12 19:21:20 UTC) #2
dcarney
lgtm
5 years, 9 months ago (2015-03-12 19:34:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005693002/1
5 years, 9 months ago (2015-03-13 07:21:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-13 07:39:58 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 07:40:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0697e929529b9467f6f5fe04509d57ff8e22c098
Cr-Commit-Position: refs/heads/master@{#27174}

Powered by Google App Engine
This is Rietveld 408576698