Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1005583002: Revert of Ignore public API checks if COMMIT=false is in the description (Closed)

Created:
5 years, 9 months ago by mtklein
Modified:
5 years, 9 months ago
Reviewers:
borenet, rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Ignore public API checks if COMMIT=false is in the description (patchset #4 id:80001 of https://codereview.chromium.org/1006473002/) Reason for revert: I cannot upload patches: ~/skia (skskp) $ git clu --bypass-hooks ++ git log -1 --pretty=%B + git cl upload -t update Using 50% similarity for rename/copy detection. Override with --similarity. Loaded authentication cookies from /Users/mtklein/.codereview_upload_cookies Running presubmit upload checks ... ** Presubmit ERRORS ** Since the CL is editing public API, you must have an LGTM from one of: ('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org', 'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com') Original issue's description: > Ignore public API checks if COMMIT=false is in the description > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/d1783aefcc0da86c5ff1d124c54704252d817621 TBR=borenet@google.com,rmistry@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/a10ea431cf9e283696bab1cac1457d4fa92f9c06

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M PRESUBMIT.py View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Ignore public API checks if COMMIT=false is in the description
5 years, 9 months ago (2015-03-12 16:33:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005583002/1
5 years, 9 months ago (2015-03-12 16:33:40 UTC) #2
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 16:33:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a10ea431cf9e283696bab1cac1457d4fa92f9c06

Powered by Google App Engine
This is Rietveld 408576698