Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 1005553004: cc: Add support for handling authoritative vsync interval (Closed)

Created:
5 years, 9 months ago by simonhong
Modified:
5 years, 9 months ago
Reviewers:
brianderson, mithro-old
CC:
chromium-reviews, cc-bugs_chromium.org, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Add support for handling authoritative vsync interval This is partial cl from https://codereview.chromium.org/775143003/ for easy reviewing. For now, authoritative vsync interval is handled by CompositorVsyncManager. It will not be used when BeginFrame scheduling is enabled on aura. Instead, it will be handled by scheduler. In the next cl, BeginFrame sheduling on aura(and ash) will be turned on. R=brianderson@chromium.org, mithro@mithis.com BUG=372086 TEST=cc_unittests Committed: https://crrev.com/298590fea3aa0a7dc68bc4d3753baad106001bc4 Cr-Commit-Position: refs/heads/master@{#322125}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -2 lines) Patch
M cc/scheduler/scheduler.h View 2 chunks +5 lines, -0 lines 0 comments Download
M cc/scheduler/scheduler.cc View 3 chunks +15 lines, -2 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M cc/test/fake_proxy.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/test/scheduler_test_common.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/trees/proxy.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/trees/thread_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/thread_proxy.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
simonhong
PTAL!
5 years, 9 months ago (2015-03-24 15:00:37 UTC) #1
brianderson
To verify, the intent of this patch is to only allow the scheduler to handle ...
5 years, 9 months ago (2015-03-25 01:16:55 UTC) #3
simonhong
On 2015/03/25 01:16:55, brianderson wrote: > To verify, the intent of this patch is to ...
5 years, 9 months ago (2015-03-25 02:04:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005553004/1
5 years, 9 months ago (2015-03-25 02:05:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/1176)
5 years, 9 months ago (2015-03-25 04:45:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005553004/1
5 years, 9 months ago (2015-03-25 05:22:49 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 06:51:27 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 06:51:49 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/298590fea3aa0a7dc68bc4d3753baad106001bc4
Cr-Commit-Position: refs/heads/master@{#322125}

Powered by Google App Engine
This is Rietveld 408576698