chrome/browser/ui/startup/default_browser_prompt.cc - Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/default_browser_prompt.cc

Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: someday it will work Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/pdf/pdf_unsupported_feature.cc ('k') | chrome/browser/ui/webui/extensions/extension_settings_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/startup/default_browser_prompt.cc

diff --git a/chrome/browser/ui/startup/default_browser_prompt.cc b/chrome/browser/ui/startup/default_browser_prompt.cc

index 5016ee2a00cf6012bf24f8c2e66ed1798d3a23a0..6aacfc24794e485a23fd81cc684ed96e41d778f1 100644

--- a/chrome/browser/ui/startup/default_browser_prompt.cc

+++ b/chrome/browser/ui/startup/default_browser_prompt.cc

@@ -244,11 +244,11 @@ void ShowDefaultBrowserPrompt(Profile* profile, HostDesktopType desktop_type) {

const std::string disable_version_string =

g_browser_process->local_state()->GetString(

prefs::kBrowserSuppressDefaultBrowserPrompt);

- const Version disable_version(disable_version_string);

+ const base::Version disable_version(disable_version_string);

DCHECK(disable_version_string.empty() || disable_version.IsValid());

if (disable_version.IsValid()) {

const chrome::VersionInfo version_info;

- if (disable_version.Equals(Version(version_info.Version())))

+ if (disable_version.Equals(base::Version(version_info.Version())))

return;

}