chrome/browser/prefs/session_startup_pref.cc - Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/session_startup_pref.cc

Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: someday it will work Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/prefs/session_startup_pref.cc

diff --git a/chrome/browser/prefs/session_startup_pref.cc b/chrome/browser/prefs/session_startup_pref.cc

index 69bd41858ea091181f23d51dff50ad6fb0a85a7b..e28872a97d63f744f380bc8b69a52c241acbbf09 100644

--- a/chrome/browser/prefs/session_startup_pref.cc

+++ b/chrome/browser/prefs/session_startup_pref.cc

@@ -256,8 +256,8 @@ void SessionStartupPref::MigrateMacDefaultPrefIfNecessary(PrefService* prefs) {

bool old_profile_version =

!prefs->FindPreference(

prefs::kProfileCreatedByVersion)->IsDefaultValue() &&

- Version(prefs->GetString(prefs::kProfileCreatedByVersion)).IsOlderThan(

- "21.0.1180.0");

+ base::Version(prefs->GetString(prefs::kProfileCreatedByVersion)).

+ IsOlderThan("21.0.1180.0");

if (old_profile_version && TypeIsDefault(prefs))

prefs->SetInteger(prefs::kRestoreOnStartup, kPrefValueLast);

#endif

« no previous file with comments | « chrome/browser/plugins/plugin_metadata_unittest.cc ('k') | chrome/browser/profiles/chrome_version_service.cc » ('j') | no next file with comments »