Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1005393006: Clean up examples directory (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
ojan
CC:
ojan, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Clean up examples directory 1) Merge input example into widgets example 2) Move single-file, non-fn examples into a "raw" directory 3) Rename stocks-fn and widgets-fn to stocks and widgets R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/98d6b5c234f0ca239c9d75564fb0ff96ad85bc63

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-32 lines, -30341 lines) Patch
M sky/README.md View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/home.sky View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/examples/input/index.sky View 1 chunk +0 lines, -10 lines 0 comments Download
D sky/examples/input/input_app.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D sky/examples/painting/circle.sky View 1 chunk +0 lines, -24 lines 0 comments Download
A + sky/examples/raw/circle.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/raw/spinning-square.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/raw/touch-demo.sky View 1 chunk +5 lines, -1 line 0 comments Download
D sky/examples/spinning-square.sky View 1 chunk +0 lines, -31 lines 0 comments Download
D sky/examples/stocks-fn/data/stock_data_0.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks-fn/data/stock_data_1.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks-fn/data/stock_data_10.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks-fn/data/stock_data_11.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks-fn/data/stock_data_12.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks-fn/data/stock_data_13.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks-fn/data/stock_data_14.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks-fn/data/stock_data_15.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks-fn/data/stock_data_16.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks-fn/data/stock_data_17.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks-fn/data/stock_data_18.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks-fn/data/stock_data_19.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks-fn/data/stock_data_2.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks-fn/data/stock_data_20.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks-fn/data/stock_data_21.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks-fn/data/stock_data_22.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks-fn/data/stock_data_23.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks-fn/data/stock_data_24.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks-fn/data/stock_data_25.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks-fn/data/stock_data_26.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks-fn/data/stock_data_27.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks-fn/data/stock_data_28.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks-fn/data/stock_data_29.json View 1 chunk +0 lines, -632 lines 0 comments Download
D sky/examples/stocks-fn/data/stock_data_3.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks-fn/data/stock_data_4.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks-fn/data/stock_data_5.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks-fn/data/stock_data_6.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks-fn/data/stock_data_7.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks-fn/data/stock_data_8.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks-fn/data/stock_data_9.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/examples/stocks-fn/lib/stock_app.dart View 1 chunk +0 lines, -170 lines 0 comments Download
D sky/examples/stocks-fn/lib/stock_arrow.dart View 1 chunk +0 lines, -92 lines 0 comments Download
D sky/examples/stocks-fn/lib/stock_data.dart View 1 chunk +0 lines, -73 lines 0 comments Download
D sky/examples/stocks-fn/lib/stock_list.dart View 1 chunk +0 lines, -30 lines 0 comments Download
D sky/examples/stocks-fn/lib/stock_menu.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D sky/examples/stocks-fn/lib/stock_row.dart View 1 chunk +0 lines, -72 lines 0 comments Download
D sky/examples/stocks-fn/main.sky View 1 chunk +0 lines, -15 lines 0 comments Download
D sky/examples/stocks-fn/pubspec.yaml View 1 chunk +0 lines, -7 lines 0 comments Download
A + sky/examples/stocks/data/stock_data_0.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/data/stock_data_1.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/data/stock_data_10.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/data/stock_data_11.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/data/stock_data_12.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/data/stock_data_13.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/data/stock_data_14.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/data/stock_data_15.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/data/stock_data_16.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/data/stock_data_17.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/data/stock_data_18.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/data/stock_data_19.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/data/stock_data_2.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/data/stock_data_20.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/data/stock_data_21.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/data/stock_data_22.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/data/stock_data_23.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/data/stock_data_24.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/data/stock_data_25.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/data/stock_data_26.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/data/stock_data_27.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/data/stock_data_28.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/data/stock_data_29.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/data/stock_data_3.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/data/stock_data_4.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/data/stock_data_5.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/data/stock_data_6.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/data/stock_data_7.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/data/stock_data_8.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/data/stock_data_9.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/lib/stock_app.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/lib/stock_arrow.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/lib/stock_data.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/lib/stock_list.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/lib/stock_menu.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/lib/stock_row.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/main.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks/pubspec.yaml View 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/examples/touch-demo.sky View 1 chunk +0 lines, -65 lines 0 comments Download
D sky/examples/widgets-fn/main.sky View 1 chunk +0 lines, -15 lines 0 comments Download
D sky/examples/widgets-fn/widgets_app.dart View 1 chunk +0 lines, -39 lines 0 comments Download
A + sky/examples/widgets/main.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/widgets/widgets_app.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/framework/README.md View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-26 21:26:56 UTC) #1
ojan
lgtm
5 years, 9 months ago (2015-03-26 21:28:01 UTC) #2
abarth-chromium
5 years, 9 months ago (2015-03-26 21:32:51 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
98d6b5c234f0ca239c9d75564fb0ff96ad85bc63 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698