Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: public/platform/modules/notifications/WebNotificationData.h

Issue 1005353002: Add data property in persistent web notification (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/platform/modules/notifications/WebNotificationData.h
diff --git a/public/platform/modules/notifications/WebNotificationData.h b/public/platform/modules/notifications/WebNotificationData.h
index 5b825d1598fbfd12cbfeebf3379122d578a513a3..6a20028809fc2906db47d5d4844eeb2861bf9b1d 100644
--- a/public/platform/modules/notifications/WebNotificationData.h
+++ b/public/platform/modules/notifications/WebNotificationData.h
@@ -23,7 +23,7 @@ struct WebNotificationData {
{
}
- WebNotificationData(const WebString& title, Direction direction, const WebString& lang, const WebString& body, const WebString& tag, const WebURL& icon, bool silent)
+ WebNotificationData(const WebString& title, Direction direction, const WebString& lang, const WebString& body, const WebString& tag, const WebURL& icon, bool silent, const WebString& data)
: title(title)
, direction(direction)
, lang(lang)
@@ -31,6 +31,7 @@ struct WebNotificationData {
, tag(tag)
, icon(icon)
, silent(silent)
+ , data(data)
Peter Beverloo 2015/03/15 22:35:04 Sorry -- as mentioned in the previous CL, you will
Sanghyun Park 2015/03/16 00:00:21 Oops it's my mistake. Sorry. How about make 1 more
Sanghyun Park 2015/03/16 00:00:21 Oops, it's my mistake. Sorry... I'll add "data"-le
{
}
@@ -41,6 +42,7 @@ struct WebNotificationData {
WebString tag;
WebURL icon;
bool silent;
+ WebString data;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698