Source/modules/notifications/ServiceWorkerRegistrationNotifications.h - Issue 1005353002: Add data property in persistent web notification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/notifications/ServiceWorkerRegistrationNotifications.h

Issue 1005353002: Add data property in persistent web notification (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/notifications/Notification.cpp ('K') | « Source/modules/notifications/Notification.cpp ('k') | Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp » ('j') | public/platform/modules/notifications/WebNotificationData.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/notifications/ServiceWorkerRegistrationNotifications.h

diff --git a/Source/modules/notifications/ServiceWorkerRegistrationNotifications.h b/Source/modules/notifications/ServiceWorkerRegistrationNotifications.h

index 688fd3d1a424b055bef960bc88ed928d4a4df32f..d924d1646acd36442ff43d4690b63b4961e573d2 100644

--- a/Source/modules/notifications/ServiceWorkerRegistrationNotifications.h

+++ b/Source/modules/notifications/ServiceWorkerRegistrationNotifications.h

@@ -10,12 +10,13 @@

namespace blink {

+class ExceptionState;

class NotificationOptions;

class ScriptState;

class ServiceWorkerRegistrationNotifications {

public:

- static ScriptPromise showNotification(ScriptState*, ServiceWorkerRegistration&, const String& title, const NotificationOptions&);

+ static ScriptPromise showNotification(ScriptState*, ServiceWorkerRegistration&, const String& title, const NotificationOptions&, ExceptionState&);

Peter Beverloo 2015/03/15 22:35:04 micro nit: double space

Sanghyun Park 2015/03/16 00:00:21 Oops, I'll fix this..

};

} // namespace blink