Issue 1005193002: Sync the Event, EventTarget and CustomEvent interfaces with the spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1005193002: Sync the Event, EventTarget and CustomEvent interfaces with the spec (Closed)

Created:
5 years, 9 months ago by philipj_slow

Modified:
5 years, 9 months ago

Reviewers:
Jens Widell

CC:
blink-reviews, vivekg, arv+blink, Inactive, vivekg_samsung

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Sync the Event, EventTarget and CustomEvent interfaces with the spec https://dom.spec.whatwg.org/#interface-event https://dom.spec.whatwg.org/#interface-eventtarget https://dom.spec.whatwg.org/#interface-customevent Note that the EventListener argument for add/removeEventListener() is named callback in the spec but left as listener here, as custom code in Source/bindings/templates/methods.cpp to deal with missing arguments depends on it. Sorting this out is left to http://crbug.com/353484 There are no observable changes to the generated code. BUG=460722, 353484 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191913

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -42 lines)			Patch
M	Source/core/events/CustomEvent.idl	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/core/events/Event.idl	View	1 chunk	+37 lines, -36 lines	0 comments	Download
M	Source/core/events/EventTarget.idl	View	2 chunks	+6 lines, -6 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005193002/1

5 years, 9 months ago (2015-03-16 11:21:49 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-16 13:03:18 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191913