Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Unified Diff: Source/core/events/EventTarget.idl

Issue 1005193002: Sync the Event, EventTarget and CustomEvent interfaces with the spec (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/events/Event.idl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/events/EventTarget.idl
diff --git a/Source/core/events/EventTarget.idl b/Source/core/events/EventTarget.idl
index 6990a08f9697b89b5bc29c7582c3c565bbe82f42..b7279b3b81ab8dd3fc725b412b11831c66bfc1ed 100644
--- a/Source/core/events/EventTarget.idl
+++ b/Source/core/events/EventTarget.idl
@@ -18,6 +18,8 @@
* Boston, MA 02110-1301, USA.
*/
+// https://dom.spec.whatwg.org/#interface-eventtarget
+
[
CheckSecurity=Window,
Custom=ToV8,
@@ -26,11 +28,9 @@
] interface EventTarget {
// FIXME: first 2 args should be required, but throwing TypeError breaks
// legacy content. http://crbug.com/353484
- void addEventListener(optional DOMString? type,
- optional EventListener listener,
- optional boolean useCapture);
- void removeEventListener(optional DOMString? type,
- optional EventListener listener,
- optional boolean useCapture);
+ // FIXME: type should not be nullable.
+ // FIXME: capture should have a default value false.
+ void addEventListener(optional DOMString? type, optional EventListener? listener, optional boolean capture);
+ void removeEventListener(optional DOMString? type, optional EventListener? listener, optional boolean capture);
[RaisesException] boolean dispatchEvent(Event event);
};
« no previous file with comments | « Source/core/events/Event.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698