Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1005173004: Revert of Revert of Revert of Revert of Change device creation to see the (optional) layer-paint (Closed)

Created:
5 years, 9 months ago by reed2
Modified:
5 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Revert of Revert of Revert of Change device creation to see the (optional) layer-paint (patchset #1 id:1 of https://codereview.chromium.org/1001423002/) Reason for revert: chrome now has the new virtual, so trying again Original issue's description: > Revert of Revert of Revert of Change device creation to see the (optional) layer-paint (patchset #1 id:1 of https://codereview.chromium.org/1006923002/) > > Reason for revert: > platform_canvas tests failures > > skia_unittests (with patch) skia_unittests (with patch) PlatformCanvas.TranslateLayer failed 2 > Flakiness dashboard > > failures: > PlatformCanvas.TranslateLayer > PlatformCanvas.FillLayer > > Original issue's description: > > Revert of Revert of Change device creation to see the (optional) layer-paint (patchset #1 id:1 of https://codereview.chromium.org/1008863002/) > > > > Reason for revert: > > guard in chrome has landed > > > > Original issue's description: > > > Revert of Change device creation to see the (optional) layer-paint (patchset #9 id:160001 of https://codereview.chromium.org/988413003/) > > > > > > Reason for revert: > > > need to have chrome opt-in for the older API before this can land (in chrome) > > > > > > Original issue's description: > > > > Change device creation to see the (optional) layer-paint > > > > > > > > Motivation: > > > > > > > > PDFDevice currently relies on 1) being told that the layer's paint has an imagefilter, and in the case, it creates a rasterdevice. It then relies on (2) canvas itself sniffing the layer's paint and offering to apply-the-imagefilter to call drawSprite instead of drawDevice. > > > > > > > > This subtle interchange is fragile, and also does not support other unsupported PDF features like colorfilters. This CL is a step toward making this use-raster-instead-of-native approach to layers more completely in the subclass' hands. > > > > > > > > Committed: https://skia.googlesource.com/skia/+/1182d9a96b80bd12183ee7c81325a979a51ee0c0 > > > > > > TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > > > > Committed: https://skia.googlesource.com/skia/+/0e040f7da2fdfeb49aa60d24117306e3b1e6ea90 > > > > TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > > > Committed: https://skia.googlesource.com/skia/+/f7076a13e2d4269903b34ef2780e1c84723e4477 > > TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://skia.googlesource.com/skia/+/8e14d660b2a434bc708a70180c84210883611683 TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/307d1ed129ff75eb64137dea75df858f9e250b69

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -92 lines) Patch
M include/core/SkBitmapDevice.h View 2 chunks +2 lines, -6 lines 0 comments Download
M include/core/SkCanvas.h View 1 chunk +1 line, -2 lines 0 comments Download
M include/core/SkDevice.h View 4 chunks +28 lines, -22 lines 0 comments Download
M include/device/xps/SkXPSDevice.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkCanvas.cpp View 5 chunks +20 lines, -23 lines 0 comments Download
M src/core/SkDevice.cpp View 2 chunks +6 lines, -9 lines 0 comments Download
M src/core/SkDeviceImageFilterProxy.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/device/xps/SkXPSDevice.cpp View 2 chunks +1 line, -4 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pdf/SkPDFDevice.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 chunk +8 lines, -2 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 3 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
reed2
Created Revert of Revert of Revert of Revert of Change device creation to see the ...
5 years, 9 months ago (2015-03-14 02:52:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005173004/1
5 years, 9 months ago (2015-03-14 02:52:47 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/307d1ed129ff75eb64137dea75df858f9e250b69
5 years, 9 months ago (2015-03-14 02:53:03 UTC) #3
reed2
5 years, 9 months ago (2015-03-14 03:05:00 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1005183003/ by reed@chromium.org.

The reason for reverting is: arrrg. this is a staging nightmare. override
required on the chrome side. must revert (again).

Powered by Google App Engine
This is Rietveld 408576698