Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Issue 10050005: Mac: define GLeglImageOES type.

Created:
8 years, 8 months ago by apatrick_chromium
Modified:
8 years, 8 months ago
Reviewers:
jbates
CC:
chromium-reviews, dhollowa+watch_chromium.org
Visibility:
Public.

Description

Mac: define GLeglImageOES type. It's used by a GLES2 extension but we still want the null binding on mac and this type is part of the signature.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/gfx/gl/gl_bindings.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
apatrick_chromium
8 years, 8 months ago (2012-04-11 01:19:28 UTC) #1
jbates
8 years, 8 months ago (2012-04-11 21:48:10 UTC) #2
On 2012/04/11 01:19:28, apatrick_chromium wrote:

Are you sure this fixes something? The full error output was:


In file included from
../../content/common/gpu/image_transport_surface_mac.cc:14:
In file included from ../../ui/gfx/gl/gl_bindings.h:89:
gen/ui/gfx/gl/gl_bindings_autogen_gl.h:73:81: error: unknown type name
'GLeglImageOES'
typedef void (GL_BINDING_CALL *glEGLImageTargetTexture2DOESProc)(GLenum target,
GLeglImageOES image);
                                                                               
^
gen/ui/gfx/gl/gl_bindings_autogen_gl.h:74:91: error: unknown type name
'GLeglImageOES'
typedef void (GL_BINDING_CALL
*glEGLImageTargetRenderbufferStorageOESProc)(GLenum target, GLeglImageOES
image);
                                                                                
         ^
gen/ui/gfx/gl/gl_bindings_autogen_gl.h:106:83: error: unknown type name
'GLint64'
typedef void (GL_BINDING_CALL *glGetQueryObjecti64vProc)(GLuint id, GLenum
pname, GLint64* params);
                                                                                
 ^
gen/ui/gfx/gl/gl_bindings_autogen_gl.h:108:84: error: unknown type name
'GLuint64'
typedef void (GL_BINDING_CALL *glGetQueryObjectui64vProc)(GLuint id, GLenum
pname, GLuint64* params);
                                                                                
  ^
gen/ui/gfx/gl/gl_bindings_autogen_gl.h:205:34: error: C++ requires a type
specifier for all declarations
typedef GLsync (GL_BINDING_CALL *glFenceSyncProc)(GLenum condition, GLbitfield
flags);
                                ~^
gen/ui/gfx/gl/gl_bindings_autogen_gl.h:205:9: error: C++ requires a type
specifier for all declarations
typedef GLsync (GL_BINDING_CALL *glFenceSyncProc)(GLenum condition, GLbitfield
flags);
~~~~~~~ ^
gen/ui/gfx/gl/gl_bindings_autogen_gl.h:205:16: error: function cannot return
function type 'int (GLenum, GLbitfield)'
typedef GLsync (GL_BINDING_CALL *glFenceSyncProc)(GLenum condition, GLbitfield
flags);
               ^
gen/ui/gfx/gl/gl_bindings_autogen_gl.h:423:18: error: unknown type name
'glFenceSyncProc'; did you mean 'glDeleteSyncProc'?
GL_EXPORT extern glFenceSyncProc g_glFenceSync;
                 ^~~~~~~~~~~~~~~
                 glDeleteSyncProc
gen/ui/gfx/gl/gl_bindings_autogen_gl.h:206:32: note: 'glDeleteSyncProc' declared
here
typedef void (GL_BINDING_CALL *glDeleteSyncProc)(GLsync sync);

Those errors all went away when I moved the #include
"content/common/view_messages.h" to after gl_bindings.h.

Powered by Google App Engine
This is Rietveld 408576698