Issue 1004933003: favor DCHECK_CURRENTLY_ON for better logs in components/

Issue 1004933003: favor DCHECK_CURRENTLY_ON for better logs in components/ (Closed)

Created:
5 years, 9 months ago by Mostyn Bramley-Moore

Modified:
5 years, 9 months ago

Reviewers:
Cait (Slow)

CC:
chromium-reviews, kalyank, jam, sadrul, darin-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

favor DCHECK_CURRENTLY_ON for better logs in components/ BUG=466848 Committed: https://crrev.com/ad1e8c96d325af5efcb730c027ed240b2a8d19cb Cr-Commit-Position: refs/heads/master@{#322240}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -63 lines)			Patch
M	components/crash/browser/crash_dump_manager_android.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	components/crash/browser/crash_handler_host_linux.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/feedback/feedback_data.cc	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	components/metrics/profiler/tracking_synchronizer.cc	View	10 chunks	+14 lines, -14 lines	0 comments	Download
M	components/nacl/browser/nacl_file_host.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/nacl/browser/pnacl_host.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/navigation_interception/intercept_navigation_delegate.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/navigation_interception/intercept_navigation_resource_throttle.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	components/precache/content/precache_manager.cc	View	7 chunks	+7 lines, -7 lines	0 comments	Download
M	components/storage_monitor/media_storage_util.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/storage_monitor/storage_monitor_chromeos.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	components/storage_monitor/storage_monitor_linux.cc	View	8 chunks	+11 lines, -11 lines	0 comments	Download
M	components/storage_monitor/volume_mount_watcher_win.cc	View	8 chunks	+8 lines, -8 lines	0 comments	Download
M	components/wallpaper/wallpaper_manager_base.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1004933003/1

5 years, 9 months ago (2015-03-25 20:42:17 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-25 21:52:13 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ad1e8c96d325af5efcb730c027ed240b2a8d19cb
Cr-Commit-Position: refs/heads/master@{#322240}