components/navigation_interception/intercept_navigation_resource_throttle.cc - Issue 1004933003: favor DCHECK_CURRENTLY_ON for better logs in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/navigation_interception/intercept_navigation_resource_throttle.cc

Issue 1004933003: favor DCHECK_CURRENTLY_ON for better logs in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/navigation_interception/intercept_navigation_delegate.cc ('k') | components/precache/content/precache_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/navigation_interception/intercept_navigation_resource_throttle.cc

diff --git a/components/navigation_interception/intercept_navigation_resource_throttle.cc b/components/navigation_interception/intercept_navigation_resource_throttle.cc

index 675c060e1e66f5653bd85cc03df365dc7223ad17..05741e65c2101bdc3219ac6933cf1fbf47d32b5a 100644

--- a/components/navigation_interception/intercept_navigation_resource_throttle.cc

+++ b/components/navigation_interception/intercept_navigation_resource_throttle.cc

@@ -73,7 +73,7 @@ InterceptNavigationResourceThrottle::InterceptNavigationResourceThrottle(

}

InterceptNavigationResourceThrottle::~InterceptNavigationResourceThrottle() {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

+ DCHECK_CURRENTLY_ON(BrowserThread::IO);

}

void InterceptNavigationResourceThrottle::WillStartRequest(bool* defer) {

@@ -134,7 +134,7 @@ bool InterceptNavigationResourceThrottle::CheckIfShouldIgnoreNavigation(

void InterceptNavigationResourceThrottle::OnResultObtained(

bool should_ignore_navigation) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

+ DCHECK_CURRENTLY_ON(BrowserThread::IO);

if (should_ignore_navigation) {

controller()->CancelAndIgnore();