chrome/test/chromedriver/client/chromedriver.py - Issue 1004843002: [chromedriver] Add Network Presets to Network Throttling feature

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/client/chromedriver.py

Issue 1004843002: [chromedriver] Add Network Presets to Network Throttling feature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleaning up Network Names; adding integration tests Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/chrome/network_conditions.cc ('K') | « chrome/test/chromedriver/chrome/network_list.cc ('k') | chrome/test/chromedriver/embed_networks_in_cpp.py » ('j') | chrome/test/chromedriver/window_commands.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/client/chromedriver.py

diff --git a/chrome/test/chromedriver/client/chromedriver.py b/chrome/test/chromedriver/client/chromedriver.py

index 3700a73a06339f2d42f8505c0cd9cc5ea85bc455..0b5a6248093827a60309e5f2bca854bb1f7420fc 100644

--- a/chrome/test/chromedriver/client/chromedriver.py

+++ b/chrome/test/chromedriver/client/chromedriver.py

@@ -372,6 +372,10 @@ class ChromeDriver(object):

}

self.ExecuteCommand(Command.SET_NETWORK_CONDITIONS, params)

+ def SetNetworkConditionsName(self, network_name):

+ self.ExecuteCommand(

+ Command.SET_NETWORK_CONDITIONS, {'network_name': network_name})

def GetNetworkConditions(self):

conditions = self.ExecuteCommand(Command.GET_NETWORK_CONDITIONS)

return {