Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 1004843002: [chromedriver] Add Network Presets to Network Throttling feature (Closed)

Created:
5 years, 9 months ago by srawlins
Modified:
5 years, 9 months ago
Reviewers:
samuong
CC:
chromium-reviews, samuong+watch_chromium.org, stgao
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Network Presets to Network Throttling feature BUG= Committed: https://crrev.com/0d53d7a98e6fb3faf3a0865b830f783d7e60eb98 Cr-Commit-Position: refs/heads/master@{#320987}

Patch Set 1 #

Patch Set 2 : Cleaning up Network Names; adding integration tests #

Total comments: 15

Patch Set 3 : Addressing comments #

Patch Set 4 : More Addressing comments #

Total comments: 2

Patch Set 5 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+318 lines, -31 lines) Patch
M chrome/chrome_tests.gypi View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/chrome/network_conditions.h View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
A chrome/test/chromedriver/chrome/network_conditions.cc View 1 2 1 chunk +85 lines, -0 lines 0 comments Download
A chrome/test/chromedriver/chrome/network_list.h View 1 1 chunk +15 lines, -0 lines 0 comments Download
A chrome/test/chromedriver/chrome/network_list.cc View 1 1 chunk +25 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/client/chromedriver.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/test/chromedriver/embed_networks_in_cpp.py View 1 1 chunk +88 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/test/run_py_tests.py View 1 2 3 4 4 chunks +39 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/window_commands.cc View 1 2 3 4 2 chunks +45 lines, -31 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
srawlins
OK Sam, this should be ready to go.
5 years, 9 months ago (2015-03-12 22:30:06 UTC) #3
samuong
This looks pretty good, just a few small comments. https://codereview.chromium.org/1004843002/diff/40001/chrome/test/chromedriver/chrome/network_conditions.cc File chrome/test/chromedriver/chrome/network_conditions.cc (right): https://codereview.chromium.org/1004843002/diff/40001/chrome/test/chromedriver/chrome/network_conditions.cc#newcode9 chrome/test/chromedriver/chrome/network_conditions.cc:9: ...
5 years, 9 months ago (2015-03-13 22:30:51 UTC) #4
srawlins
Thanks for reviewing, Sam! Addressed comments. https://codereview.chromium.org/1004843002/diff/40001/chrome/test/chromedriver/chrome/network_conditions.cc File chrome/test/chromedriver/chrome/network_conditions.cc (right): https://codereview.chromium.org/1004843002/diff/40001/chrome/test/chromedriver/chrome/network_conditions.cc#newcode9 chrome/test/chromedriver/chrome/network_conditions.cc:9: #include "chrome/test/chromedriver/chrome/network_conditions.h" On ...
5 years, 9 months ago (2015-03-16 18:26:29 UTC) #5
samuong
https://codereview.chromium.org/1004843002/diff/40001/chrome/test/chromedriver/chrome/network_conditions.cc File chrome/test/chromedriver/chrome/network_conditions.cc (right): https://codereview.chromium.org/1004843002/diff/40001/chrome/test/chromedriver/chrome/network_conditions.cc#newcode55 chrome/test/chromedriver/chrome/network_conditions.cc:55: continue; On 2015/03/16 18:26:28, srawlins wrote: > On 2015/03/13 ...
5 years, 9 months ago (2015-03-16 18:43:11 UTC) #6
srawlins
https://codereview.chromium.org/1004843002/diff/40001/chrome/test/chromedriver/window_commands.cc File chrome/test/chromedriver/window_commands.cc (right): https://codereview.chromium.org/1004843002/diff/40001/chrome/test/chromedriver/window_commands.cc#newcode883 chrome/test/chromedriver/window_commands.cc:883: Status status = FindPresetNetwork(network_name, &network_conditions); On 2015/03/16 18:43:10, samuong ...
5 years, 9 months ago (2015-03-16 19:23:11 UTC) #7
samuong
thanks sam, lgtm with one nit https://codereview.chromium.org/1004843002/diff/80001/chrome/test/chromedriver/window_commands.cc File chrome/test/chromedriver/window_commands.cc (right): https://codereview.chromium.org/1004843002/diff/80001/chrome/test/chromedriver/window_commands.cc#newcode881 chrome/test/chromedriver/window_commands.cc:881: network_conditions.reset(new NetworkConditions()); nit: ...
5 years, 9 months ago (2015-03-16 19:38:08 UTC) #8
srawlins
https://codereview.chromium.org/1004843002/diff/80001/chrome/test/chromedriver/window_commands.cc File chrome/test/chromedriver/window_commands.cc (right): https://codereview.chromium.org/1004843002/diff/80001/chrome/test/chromedriver/window_commands.cc#newcode881 chrome/test/chromedriver/window_commands.cc:881: network_conditions.reset(new NetworkConditions()); On 2015/03/16 19:38:08, samuong wrote: > nit: ...
5 years, 9 months ago (2015-03-17 20:38:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1004843002/100001
5 years, 9 months ago (2015-03-17 20:38:37 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:100001)
5 years, 9 months ago (2015-03-17 21:53:48 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 21:54:39 UTC) #14
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/0d53d7a98e6fb3faf3a0865b830f783d7e60eb98
Cr-Commit-Position: refs/heads/master@{#320987}

Powered by Google App Engine
This is Rietveld 408576698