Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1004733009:
Add post upload hook to substitute hashtags for their mapped text (Closed)
DescriptionAdd post upload hook to substitute hashtags for their mapped text
BUG=skia:3586
NOTRY=true
Committed: https://skia.googlesource.com/skia/+/3cfd1ad6c7dcb00d420608cef0d4370aeda3f2f1
Patch Set 1 : Initial upload #Patch Set 2 : Typo #
Total comments: 4
Patch Set 3 : Support multiple lines and CQ keywords that need appending #Patch Set 4 : Minor fixes #Messages
Total messages: 31 (24 generated)
rmistry@google.com changed reviewers: + mtklein@google.com
https://codereview.chromium.org/1004733009/diff/20001/HASHTAGS File HASHTAGS (right): https://codereview.chromium.org/1004733009/diff/20001/HASHTAGS#newcode3 HASHTAGS:3: # Please see ${bug_number} for more details. 3586 ? https://codereview.chromium.org/1004733009/diff/20001/HASHTAGS#newcode15 HASHTAGS:15: try_android_test_n7_d,CQ_INCLUDE_TRYBOTS=client.skia.android:Test-Android-Nexus7-Tegra3-Arm7-Debug Does piling more than one thing together on the same line work downstream? E.g. floats,BUG=skia:somebug CQ_INCLUDE_TRYBOTS=some-trybot I guess we could make it work like this? floats,BUG=skia:somebug,CQ_INCLUDE_TRYBOTS=some-trybot where each comma-separated section is included with a new line if not already present? Also, just curious, do things like CQ_INCLUDE_TRYBOTS=foo CQ_INCLUDE_TRYBOTS=bar compose, and run foo and bar?
Forgot an LGTM. This looks useful and correct as it is. My questions were all about next steps.
Patchset #3 (id:40001) has been deleted
Patchset #3 (id:60001) has been deleted
Patchset #4 (id:100001) has been deleted
Patchset #3 (id:80001) has been deleted
Patchset #3 (id:120001) has been deleted
Patchset #3 (id:140001) has been deleted
Patchset #4 (id:180001) has been deleted
Patchset #9 (id:280001) has been deleted
Patchset #6 (id:240001) has been deleted
Patchset #7 (id:130003) has been deleted
Patchset #8 (id:320001) has been deleted
Patchset #8 (id:340001) has been deleted
Patchset #8 (id:360001) has been deleted
Patchset #3 (id:160001) has been deleted
Patchset #4 (id:220001) has been deleted
Patchset #4 (id:90003) has been deleted
Patchset #3 (id:200001) has been deleted
Patchset #4 (id:380001) has been deleted
Patchset #5 (id:180002) has been deleted
Patchset #4 (id:400001) has been deleted
Patchset #3 (id:300001) has been deleted
Patchset #3 (id:430001) has been deleted
https://codereview.chromium.org/1004733009/diff/20001/HASHTAGS File HASHTAGS (right): https://codereview.chromium.org/1004733009/diff/20001/HASHTAGS#newcode3 HASHTAGS:3: # Please see ${bug_number} for more details. On 2015/03/25 12:59:46, mtklein wrote: > 3586 ? Done. https://codereview.chromium.org/1004733009/diff/20001/HASHTAGS#newcode15 HASHTAGS:15: try_android_test_n7_d,CQ_INCLUDE_TRYBOTS=client.skia.android:Test-Android-Nexus7-Tegra3-Arm7-Debug On 2015/03/25 12:59:46, mtklein wrote: > Does piling more than one thing together on the same line work downstream? E.g. > floats,BUG=skia:somebug CQ_INCLUDE_TRYBOTS=some-trybot > > I guess we could make it work like this? > floats,BUG=skia:somebug,CQ_INCLUDE_TRYBOTS=some-trybot > where each comma-separated section is included with a new line if not already > present? SGTM. Done. > > Also, just curious, do things like > CQ_INCLUDE_TRYBOTS=foo > CQ_INCLUDE_TRYBOTS=bar > compose, and run foo and bar? I tried this out in https://codereview.chromium.org/1003273008/ and it did not work. Multiple BUG lines do work but looks like multiple CQ_INCLUDE_TRYBOTS lines do not. I took a look at the CQ code and it looked difficult to add support for it there so I just made a _HandleAppendingCQKeywords function in the PRESUBMIT that handles this. Done.
lgtm
The CQ bit was checked by rmistry@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1004733009/470001
Message was sent while issue was closed.
Committed patchset #4 (id:470001) as https://skia.googlesource.com/skia/+/3cfd1ad6c7dcb00d420608cef0d4370aeda3f2f1 |
