HASHTAGS - Issue 1004733009: Add post upload hook to substitute hashtags for their mapped text

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: HASHTAGS

Issue 1004733009: Add post upload hook to substitute hashtags for their mapped text (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: Typo Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # This file is used by the post upload hook in the PRESUBMIT file to

	2 # automatically change a CL's description based on the specified hashtags.

	3 # Please see ${bug_number} for more details.
	mtklein 2015/03/25 12:59:46 3586 ? 3586 ? rmistry 2015/03/25 17:24:01 Done. Show quoted text On 2015/03/25 12:59:46, mtklein wrote: > 3586 ? Done.
	4 #

	5 # The format of this file is:

	6 # hashtag_name,mapped_text

	7 #

	8 # Here are some examples:

	9 # * "projectxyz, BUG=skia:123" would convert "#projectxyz" into "BUG=skia:123".

	10 # * "notry, NOTRY=true" would convert "#notry" into "NOTRY=true".

	11

	12 dummyproject,BUG=skia:2139

	13 notry,NOTRY=true

	14 nocommit,COMMIT=false

	15 try_android_test_n7_d,CQ_INCLUDE_TRYBOTS=client.skia.android:Test-Android-Nexus7 -Tegra3-Arm7-Debug
	mtklein 2015/03/25 12:59:46 Does piling more than one thing together on the sa Does piling more than one thing together on the same line work downstream? E.g. floats,BUG=skia:somebug CQ_INCLUDE_TRYBOTS=some-trybot I guess we could make it work like this? floats,BUG=skia:somebug,CQ_INCLUDE_TRYBOTS=some-trybot where each comma-separated section is included with a new line if not already present? Also, just curious, do things like CQ_INCLUDE_TRYBOTS=foo CQ_INCLUDE_TRYBOTS=bar compose, and run foo and bar? rmistry 2015/03/25 17:24:01 SGTM. Done. Show quoted text On 2015/03/25 12:59:46, mtklein wrote: > Does piling more than one thing together on the same line work downstream? E.g. > floats,BUG=skia:somebug CQ_INCLUDE_TRYBOTS=some-trybot > > I guess we could make it work like this? > floats,BUG=skia:somebug,CQ_INCLUDE_TRYBOTS=some-trybot > where each comma-separated section is included with a new line if not already > present? SGTM. Done. Show quoted text > > Also, just curious, do things like > CQ_INCLUDE_TRYBOTS=foo > CQ_INCLUDE_TRYBOTS=bar > compose, and run foo and bar? I tried this out in https://codereview.chromium.org/1003273008/ and it did not work. Multiple BUG lines do work but looks like multiple CQ_INCLUDE_TRYBOTS lines do not. I took a look at the CQ code and it looked difficult to add support for it there so I just made a _HandleAppendingCQKeywords function in the PRESUBMIT that handles this. Done.
OLD	NEW

« no previous file with comments | « no previous file | PRESUBMIT.py » ('j') | no next file with comments »