Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 1004733006: Try to make a NOTREACHED definition suitable for win8. (Closed)

Created:
5 years, 6 months ago by Tom Sepez
Modified:
5 years, 6 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Try to make a NOTREACHED definition suitable for win8. See http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gn_rel/builds/5674 Testing this is a two-step process: land CL to pdfium, then try DEPS roll in chromium against this version on the win8 trybots. TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/b0115665b0f33971f1b7077740d51e155583cec0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/base/logging.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Tom Sepez
Committed patchset #1 (id:1) manually as b0115665b0f33971f1b7077740d51e155583cec0 (presubmit successful).
5 years, 6 months ago (2015-03-23 16:34:04 UTC) #1
Lei Zhang
Have you tried this on Windows to make sure assert(false) doesn't trigger the same warning? ...
5 years, 6 months ago (2015-03-23 18:54:34 UTC) #2
Tom Sepez
Lei, by all means, try. More data is better. I got a green result on ...
5 years, 6 months ago (2015-03-23 18:56:54 UTC) #3
Lei Zhang
5 years, 6 months ago (2015-03-23 20:40:30 UTC) #4
Message was sent while issue was closed.
This does fix the warning, so lgtm.

BTW commit 7b4c0028550c32b0b773368ff4bbcc1d1adcd928 also turned off this
warning.

Powered by Google App Engine
This is Rietveld 408576698