Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: third_party/base/logging.h

Issue 1004733006: Try to make a NOTREACHED definition suitable for win8. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/base/logging.h
diff --git a/third_party/base/logging.h b/third_party/base/logging.h
index d24f93b2a12f46b6c3ec448ae5f91ac2552641bb..98ed9c5da0059d40ccd26d82fd2a0468053da4c9 100644
--- a/third_party/base/logging.h
+++ b/third_party/base/logging.h
@@ -5,6 +5,7 @@
#ifndef PDFIUM_THIRD_PARTY_BASE_LOGGING_H_
#define PDFIUM_THIRD_PARTY_BASE_LOGGING_H_
+#include <assert.h>
#include <stdlib.h>
#define CHECK(condition) \
@@ -13,6 +14,6 @@
*(reinterpret_cast<volatile char*>(NULL) + 42) = 0x42; \
}
-#define NOTREACHED() abort()
+#define NOTREACHED() assert(false)
#endif // PDFIUM_THIRD_PARTY_BASE_LOGGING_H_
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698