Issue 1004683003: Address review comments for r322149 (package script for instrumented libs).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1004683003: Address review comments for r322149 (package script for instrumented libs). (Closed)

Created:
5 years, 9 months ago by earthdok

Modified:
5 years, 9 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Address review comments for r322149 (package script for instrumented libs). I accidentally landed the wrong patchset. :( BUG=462636 TBR=glider@chromium.org NOTRY=true Committed: https://crrev.com/3b966a9ed8b4af7fb9dd54611037ec79e66aa3ec Cr-Commit-Position: refs/heads/master@{#322150}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
	M	third_party/instrumented_libraries/scripts/build_and_package.sh	View		1 chunk	+9 lines, -5 lines	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1004683003/1

5 years, 9 months ago (2015-03-25 13:30:19 UTC) #3

commit-bot: I haz the power

5 years, 9 months ago (2015-03-25 13:31:14 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3b966a9ed8b4af7fb9dd54611037ec79e66aa3ec
Cr-Commit-Position: refs/heads/master@{#322150}