Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: third_party/instrumented_libraries/scripts/build_and_package.sh

Issue 1004683003: Address review comments for r322149 (package script for instrumented libs). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/instrumented_libraries/scripts/build_and_package.sh
diff --git a/third_party/instrumented_libraries/scripts/build_and_package.sh b/third_party/instrumented_libraries/scripts/build_and_package.sh
index 30b20dacc9659659fba214d4550df4f1a9e5aa27..0de0c914dfebf74802e7148817bbb667e85240af 100755
--- a/third_party/instrumented_libraries/scripts/build_and_package.sh
+++ b/third_party/instrumented_libraries/scripts/build_and_package.sh
@@ -30,33 +30,37 @@ function build_libraries {
esac
local archive_name=${build_type}-${ubuntu_release}
- local out_dir=out_${archive_name}
+ local out_dir=out-${archive_name}
echo "Building instrumented libraries in ${out_dir}..."
rm -rf $out_dir
mkdir $out_dir
- GYP_DEFINES="${gyp_defines} use_instrumented_libraries=1 instrumented_libraries_jobs=8" \
+ GYP_DEFINES="${gyp_defines} \
+ use_instrumented_libraries=1 instrumented_libraries_jobs=8" \
GYP_GENERATOR_FLAGS="output_dir=${out_dir}" \
gclient runhooks
- ninja -C ${out_dir}/Release instrumented_libraries
+ ninja -j4 -C ${out_dir}/Release instrumented_libraries
echo "Creating archive ${archive_name}.tgz..."
files=$(ls -1 ${out_dir}/Release/instrumented_libraries)
- tar zcf ${archive_name}.tgz -C ${out_dir}/Release/instrumented_libraries --exclude="?san/*.txt" ${files}
+ tar zcf ${archive_name}.tgz -C ${out_dir}/Release/instrumented_libraries \
+ --exclude="?san/*.txt" ${files}
echo To upload, run:
- echo upload_to_google_storage.py -b chromium-instrumented-libraries ${archive_name}.tgz
+ echo upload_to_google_storage.py -b \
+ chromium-instrumented-libraries ${archive_name}.tgz
echo You should then commit the resulting .sha1 file.
}
if ! [[ "${supported_releases}" =~ ${ubuntu_release} ]]
then
echo "Unsupported Ubuntu release: ${ubuntu_release}"
+ echo "Supported releases: ${supported_releases}"
exit 1
fi
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698