Source/core/css/resolver/FontBuilder.cpp - Issue 100463004: Make calls to AtomicString(const String&) explicit in css/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/FontBuilder.cpp

Issue 100463004: Make calls to AtomicString(const String&) explicit in css/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/resolver/FontBuilder.cpp

diff --git a/Source/core/css/resolver/FontBuilder.cpp b/Source/core/css/resolver/FontBuilder.cpp

index 115419690518dec1c0df56a131d0f964fc643a2f..5073434aebd57e09ca82051a90284025e2c27ba4 100644

--- a/Source/core/css/resolver/FontBuilder.cpp

+++ b/Source/core/css/resolver/FontBuilder.cpp

@@ -179,7 +179,7 @@ void FontBuilder::setFontFamilyValue(CSSValue* value, float effectiveZoom)

AtomicString face;

Settings* settings = m_document->settings();

if (contentValue->isString()) {

- face = contentValue->getStringValue();

+ face = AtomicString(contentValue->getStringValue());

} else if (settings) {

switch (contentValue->getValueID()) {

case CSSValueWebkitBody:

« Source/core/css/MediaQueryEvaluator.h ('K') | « Source/core/css/resolver/CSSToStyleMap.cpp ('k') | Source/core/css/resolver/StyleBuilderCustom.cpp » ('j') | no next file with comments »