Source/core/css/MediaQueryEvaluator.h - Issue 100463004: Make calls to AtomicString(const String&) explicit in css/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/MediaQueryEvaluator.h

Issue 100463004: Make calls to AtomicString(const String&) explicit in css/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/MediaQueryEvaluator.h

diff --git a/Source/core/css/MediaQueryEvaluator.h b/Source/core/css/MediaQueryEvaluator.h

index 60bd9cd78f24a44ba20b8c5d637fa3694065fff3..ab054f88f04e7904868a93867da7653afdf5ef66 100644

--- a/Source/core/css/MediaQueryEvaluator.h

+++ b/Source/core/css/MediaQueryEvaluator.h

@@ -72,7 +72,7 @@ public:

~MediaQueryEvaluator();

- bool mediaTypeMatch(const AtomicString& mediaTypeToMatch) const;

+ bool mediaTypeMatch(const String& mediaTypeToMatch) const;

eseidel 2013/12/09 18:24:21 I would have expected media queries to be atomic s

Inactive 2013/12/09 18:49:32 Media queries are not really a small set of values

Inactive 2013/12/09 19:10:59 Done. I kept this as an AtomicString.

bool mediaTypeMatchSpecific(const char* mediaTypeToMatch) const;

/** Evaluates a list of media queries */

« no previous file with comments | « Source/core/css/FontFace.cpp ('k') | Source/core/css/MediaQueryEvaluator.cpp » ('j') | no next file with comments »