Make calls to AtomicString(const String&) explicit in css/

Source/core/css/MediaQueryEvaluator.h

 /*
  * CSS Media Query Evaluator
  *
  * Copyright (C) 2006 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 54 matching lines @@
      *  for any media features
      */
     MediaQueryEvaluator(const AtomicString& acceptedMediaType, bool mediaFeatureResult = false);
     MediaQueryEvaluator(const char* acceptedMediaType, bool mediaFeatureResult = false);
 
     /** Creates evaluator which evaluates full media queries */
     MediaQueryEvaluator(const AtomicString& acceptedMediaType, Frame*, RenderStyle*);
 
     ~MediaQueryEvaluator();
 
-    bool mediaTypeMatch(const AtomicString& mediaTypeToMatch) const;
+    bool mediaTypeMatch(const String& mediaTypeToMatch) const;

[eseidel, 2013/12/09 18:24:21]

I would have expected media queries to be atomic strings.  Aren't they a very
small set of values?

[Inactive, 2013/12/09 18:49:32]

Media queries are not really a small set of values. However, this particular
code is about media types, and those are definitely a small set of values and
using AtomicString definitely makes sense:
http://www.w3.org/TR/CSS2/media.html#media-types

I switched to String here because MediaQuery::mediaType() currently returns a
String but I will look into making it return an AtomicString instead, thanks.

[Inactive, 2013/12/09 19:10:59]

Done. I kept this as an AtomicString.

     bool mediaTypeMatchSpecific(const char* mediaTypeToMatch) const;
 
     /** Evaluates a list of media queries */
     bool eval(const MediaQuerySet*, MediaQueryResultList* = 0) const;
 
     /** Evaluates media query subexpression, ie "and (media-feature: value)" part */
     bool eval(const MediaQueryExp*) const;
 
 private:
     AtomicString m_mediaType;
     Frame* m_frame; // Not owned.
     RefPtr<RenderStyle> m_style;
     bool m_expResult;
 };
 
 } // namespace
 #endif