Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1004623002: MIPS: Simplify pending message object handling. (Closed)

Created:
5 years, 9 months ago by balazs.kilvady
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Simplify pending message object handling. Port d4696c484142c601cbd691ae80164043785a3af7 Original commit message: This moves the decision whether to report a message or not to when the pending exception is propagated instead of trying to preserve the decision in a ThreadLocalTop field. BUG= Committed: https://crrev.com/811caee0e0acf8bf71dbd8dafb5e5df800784020 Cr-Commit-Position: refs/heads/master@{#27158}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -28 lines) Patch
M src/mips/full-codegen-mips.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
balazs.kilvady
5 years, 9 months ago (2015-03-12 11:02:10 UTC) #2
Michael Starzinger
LGTM.
5 years, 9 months ago (2015-03-12 12:01:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1004623002/1
5 years, 9 months ago (2015-03-12 13:30:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-12 13:54:35 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 13:54:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/811caee0e0acf8bf71dbd8dafb5e5df800784020
Cr-Commit-Position: refs/heads/master@{#27158}

Powered by Google App Engine
This is Rietveld 408576698